Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DO without EDNS #62

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

mohshami
Copy link
Contributor

Allow setting the do flag without having to explicitly enable an EDNS option.

Sometimes we would like to validate DNSSEC but not enable PADDING or any of the other options

Also this way padding won't override edns and they won't override subnet

@mohshami
Copy link
Contributor Author

mohshami commented Mar 9, 2024

Hello, where you able to take a look at this?

Thank you

Copy link
Owner

@ameshkov ameshkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't like the idea of adding OPT by default.

Let's do this only when do is true.

@mohshami
Copy link
Contributor Author

Thank you so much, something came up so I won't be able to check this for the next few days. Will get back to it as soon as I can

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants