Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update Node LTS versions in CI workflow #121

Closed
wants to merge 1 commit into from

Conversation

spencerlepine
Copy link

@spencerlepine spencerlepine commented Mar 31, 2023

Issue #, if available:

Description of changes:
Update Node LTS versions in CI workflow. Follow streams: https://github.com/amazon-connect/amazon-connect-streams/blob/master/.github/workflows/release.yml

- node: [10.x, 12.x, 14.x, 15.x]
+ node: [14.x, 16.x, 18.x, 19.x]

Why? master branch had recent issues running npm i and npm release in node 15/16. Following Node LTS support

since npm 8.3, the official way to handle vulnerabilities of subdependencies with npm is to use the overrides attributes:
docs: https://docs.npmjs.com/cli/v8/configuring-npm/package-json#overrides
ref: rogeriochaves/npm-force-resolutions#56 (comment)

Before

Screenshot 2023-03-31 at 9 12 18 AM

After

Screenshot 2023-03-31 at 10 52 12 AM

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@spencerlepine spencerlepine added the ✨ Enhancement Non-essential updates label Mar 31, 2023
@spencerlepine spencerlepine marked this pull request as ready for review March 31, 2023 16:23
@spencerlepine spencerlepine self-assigned this Mar 31, 2023
@spencerlepine spencerlepine marked this pull request as draft March 31, 2023 17:55
@spencerlepine spencerlepine changed the title add node v16 to CI workflow update Node LTS versions in CI workflow Mar 31, 2023
@spencerlepine spencerlepine added ⌛️ Pending Revision Pending PR revision or blocked, work in progress 🤖 CI labels Apr 27, 2023
@spencerlepine spencerlepine force-pushed the spenlep-nodeci-v16 branch 3 times, most recently from 412693b to 088e085 Compare May 5, 2023 18:00
@spencerlepine spencerlepine deleted the spenlep-nodeci-v16 branch September 27, 2023 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤖 CI ✨ Enhancement Non-essential updates ⌛️ Pending Revision Pending PR revision or blocked, work in progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant