Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make a release with fixed jinja2 dependency #718

Closed
sporniket opened this issue Sep 25, 2022 · 8 comments
Closed

Make a release with fixed jinja2 dependency #718

sporniket opened this issue Sep 25, 2022 · 8 comments
Labels
Milestone

Comments

@sporniket
Copy link
Contributor

Follow up of #713

Trying various things on amaranth-board project, I stumbled upon this comment mentioning issue #688, that has been solved with PR #689

However, amaranth-board is using amaranth release 0.3 (it requires a version <0.5) , that is anterior to that fix.

I believe that publishing on pypi a hotfix of 0.3 that only include #689 would solve this particular problem of amaranth-board (and eventually unmask other problems that are hidden by this dependency problem)

@sporniket
Copy link
Contributor Author

Another option would be to regularly publish (monthly or every other month) amaranth to pypi as it is, considering a twisted semver 0.Major.Minor.Fix, so that we stay at v0.3... until v0.4 is ready

@sporniket
Copy link
Contributor Author

Me again, I also succeeded to fix the CI on amaranth-board by referencing a recent commit of this github repository in setup.py instead of the package on amaranth, see PR amaranth-lang/amaranth-boards#205 . If this is more manageable/acceptable because it requires no action from the side of amaranth project.

@sporniket
Copy link
Contributor Author

@whitequark whitequark added this to the 0.4 milestone Jan 31, 2023
@whitequark whitequark changed the title [amaranth-boards] make a release with fixed jinja2 dependency Make a release with fixed jinja2 dependency Feb 3, 2023
@daquintero
Copy link

daquintero commented Aug 17, 2023

Hi! Is there any chance this could be released on pypi? It's beginning to conflict with common tools like JupyerLabn and Sphinx.

@whitequark
Copy link
Member

whitequark commented Aug 17, 2023

This will be released as a part of Amaranth 0.4. You can see the milestone here: https://github.com/amaranth-lang/amaranth/milestone/4

@daquintero
Copy link

Sorry I mixed up the version of amaranth-yosys that I was looking at the same time thinking they were the same, sounds great! Thanks for all the work.

@daquintero
Copy link

daquintero commented Aug 21, 2023

I tried to follow this same principle when adding amaranth as a dependency for my project, and worth mentioning it doesn't seem this syntax in the requirements will upload to PyPi just in case this comes up for the future for you.

Checking dist/piel-0.0.49-py2.py3-none-any.whl: PASSED
Checking dist/piel-0.0.49.tar.gz: PASSED
Uploading distributions to https://upload.pypi.org/legacy/
Uploading piel-0.0.49-py2.py3-none-any.whl
25l
  0% ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 0.0/89.7 kB • --:-- • ?
  0% ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 0.0/89.7 kB • --:-- • ?
100% ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 89.7/89.7 kB • 00:00 • 2.0 MB/s
100% ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 89.7/89.7 kB • 00:00 • 2.0 MB/s
100% ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 89.7/89.7 kB • 00:00 • 2.0 MB/s
100% ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 89.7/89.7 kB • 00:00 • 2.0 MB/s
[25](https://github.com/daquintero/piel/actions/runs/5932203509/job/16085574828#step:7:26)hWARNING  Error during upload. Retry with the --verbose option for more details. 
ERROR    HTTPError: 400 Bad Request from https://upload.pypi.org/legacy/        
         Invalid value for requires_dist. Error: Can't have direct dependency:  
         'amaranth @ git+https://github.com/amaranth-lang/amaranth.git'

Trying to think of an alternative solution atm.

The pypi issue is detailed here pypa/twine#726

Part of me thinks a automatic bumpversion-github action versioned system based on the main branch being uploaded to pypi like gdsfactory does would solve the problem https://gdsfactory.github.io/gdsfactory/ as it means most users can use the major stable versions, but any latest build versions can also be version controlled. But looking for a solution in the interim.

Issue is also detailed here https://stackoverflow.com/questions/54887301/how-can-i-use-git-repos-as-dependencies-for-my-pypi-package

@whitequark
Copy link
Member

There is no solution that you can use at the moment. You can track the progress to the Amaranth 0.4 release at https://github.com/amaranth-lang/amaranth/milestone/4.

In addition, we have made a policy change that will avoid the same issue happening in the future. You can read about it at https://amaranth-lang.org/rfcs/0021-patch-releases.html.

I am now closing this question as no action is planned until the 0.4 release and the 0.4 release will resolve this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

3 participants