Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI is broken #200

Closed
hansfbaier opened this issue Apr 15, 2022 · 5 comments
Closed

CI is broken #200

hansfbaier opened this issue Apr 15, 2022 · 5 comments

Comments

@hansfbaier
Copy link

All tests terminate with this error:

ImportError: cannot import name 'soft_unicode' from 'markupsafe' (/home/runner/work/amaranth-boards/amaranth-boards/.eggs/MarkupSafe-2.1.1-py3.10-linux-x86_64.egg/markupsafe/__init__.py)

@ghost
Copy link

ghost commented Apr 16, 2022

Yes, this is a known issue, the issue in Amaranth itself was patched with amaranth-lang/amaranth#688, while the issue with boards and testing in general is related to #128. There aren't even any tests defined in the repository so I don't see this is a practical issue and it cannot be solved without addressing #128 anyway.

@sporniket
Copy link

sporniket commented Oct 6, 2022

@whitequark , do you have a preference between my PR #205 or my ticket amaranth#718 ? So that I can close the one that you don't like ?

No problem if you don't like both, but I feel that this problem is stalling a lot of PRs.

@whitequark
Copy link
Member

I'm currently in the process of moving to another country which is taking a lot of time and effort. Once I'm done (or possibly earlier) I'm going to cut an Amaranth release which will solve this issue.

@sporniket
Copy link

ok, take care

@whitequark
Copy link
Member

CI is fixed now. There's a workaround for downgrading MarkupSafe with Amaranth 0.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants