Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to dagre-d3-es from dagre-d3 #8

Merged
merged 17 commits into from
Dec 3, 2023
Merged

Migrate to dagre-d3-es from dagre-d3 #8

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
d26c1ef
Reactor test.yml to use a variable for the node version
Robert-96 Dec 2, 2023
19a1e4c
Migrate to dagre-d3-es
Robert-96 Dec 2, 2023
64d8ee7
Update .eslintrc.js
Robert-96 Dec 2, 2023
587d100
Update webpack.config.js
Robert-96 Dec 2, 2023
d920d6d
Fix error in Actions.vue
Robert-96 Dec 2, 2023
a94c4b7
Fix typo
Robert-96 Dec 2, 2023
bbfc00a
Fix error for the dagre-d3-es migration
Robert-96 Dec 2, 2023
a019d79
Update examples
Robert-96 Dec 2, 2023
364679b
Update docs
Robert-96 Dec 2, 2023
d4295ee
Merge develop
Robert-96 Dec 2, 2023
8f65a80
Fix test.yml
Robert-96 Dec 2, 2023
19cdeb4
Update README.md
Robert-96 Dec 2, 2023
b53a325
Fix test.yml
Robert-96 Dec 2, 2023
1501bc0
Fix lint issues
Robert-96 Dec 2, 2023
96cf523
Fix lint issues
Robert-96 Dec 2, 2023
d6a0bb7
Merge develop
Robert-96 Dec 2, 2023
7625122
Refacor vue components
Robert-96 Dec 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions .eslintrc.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,7 @@ module.exports = {
],
globals: {
Atomics: 'readonly',
SharedArrayBuffer: 'readonly',
d3: 'readonly',
dagreD3: 'readonly'
SharedArrayBuffer: 'readonly'
},
parserOptions: {
ecmaVersion: 2018,
Expand Down
10 changes: 7 additions & 3 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,10 @@ on:
paths:
- 'src/**'
- 'tests/**'
- '.github/workflows/test.yml'

env:
NODE_VERSION: 16

jobs:
lint:
Expand All @@ -15,7 +19,7 @@ jobs:

- uses: actions/setup-node@v3
with:
node-version: 16
node-version: ${{ env.NODE_VERSION }}

- name: Install npm dependencies
run: |
Expand All @@ -38,7 +42,7 @@ jobs:

- uses: actions/setup-node@v3
with:
node-version: 16
node-version: ${{ env.NODE_VERSION }}

- name: Install npm dependencies
run: |
Expand Down Expand Up @@ -66,7 +70,7 @@ jobs:

- uses: actions/setup-node@v3
with:
node-version: 16
node-version: ${{ env.NODE_VERSION }}

- name: Install npm dependencies
run: |
Expand Down
3 changes: 0 additions & 3 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,14 +29,11 @@ Place the following `<script>`s near the end of your pages, right before the clo

### Required Dependencies

* [D3](https://d3js.org/)
* [dagre-d3](https://github.com/dagrejs/dagre-d3)
* [Vue.js](https://vuejs.org/)
* [lodash](https://lodash.com/)

### Optional Dependencies

* [d3-legend](https://d3-legend.susielu.com/) (__Optional__) - if you want to use the legend.
* [Milligram](https://milligram.io/) (__Optional__) - for the forms design.

## Example
Expand Down
4 changes: 0 additions & 4 deletions docs/_static/examples/edit-mode.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,10 +23,6 @@
</div>
</div>

<!-- DagreD3 and D3 -->
<script src="https://d3js.org/d3.v5.js"></script>
<script type="text/javascript" src="https://cdnjs.cloudflare.com/ajax/libs/dagre-d3/0.6.3/dagre-d3.min.js"></script>

<!-- VueJS -->
<script src="https://cdn.jsdelivr.net/npm/[email protected]/dist/vue.min.js"></script>

Expand Down
4 changes: 0 additions & 4 deletions docs/_static/examples/view-mode.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,10 +23,6 @@
</div>
</div>

<!-- DagreD3 and D3 -->
<script src="https://d3js.org/d3.v5.js"></script>
<script type="text/javascript" src="https://cdnjs.cloudflare.com/ajax/libs/dagre-d3/0.6.3/dagre-d3.min.js"></script>

<!-- VueJS -->
<script src="https://cdn.jsdelivr.net/npm/[email protected]/dist/vue.min.js"></script>

Expand Down
7 changes: 0 additions & 7 deletions docs/quickstart.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,15 +39,12 @@ Dependencies
Required Dependencies
*********************

* `D3 <https://d3js.org/>`_
* `dagre-d3 <https://github.com/dagrejs/dagre-d3>`_
* `Vue.js <https://vuejs.org/>`_
* `lodash <https://lodash.com/>`_

Optional Dependencies
*********************

* `d3-legend <https://d3-legend.susielu.com/>`_ (**Optional**) - if you want to use the legend.
* `Milligram <https://milligram.io/>`_ (**Optional**) - for the forms design.

Initialize the ModelVisualizer
Expand Down Expand Up @@ -85,10 +82,6 @@ Put it all together and your pages should look like this:
<div id="visualizer">
</div>

<!-- DagreD3 and D3 -->
<script src="https://d3js.org/d3.v5.js"></script>
<script type="text/javascript" src="https://cdnjs.cloudflare.com/ajax/libs/dagre-d3/0.6.3/dagre-d3.min.js"></script>

<!-- VueJS -->
<script src="https://cdn.jsdelivr.net/npm/vue"></script>

Expand Down
7 changes: 1 addition & 6 deletions examples/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,11 +59,6 @@
<div id="legend"></div>
<div id="visualizer"></div>

<!-- D3, DagreD3 and D3 Legend -->
<script src="https://d3js.org/d3.v5.js"></script>
<script type="text/javascript" src="https://cdnjs.cloudflare.com/ajax/libs/dagre-d3/0.6.3/dagre-d3.min.js"></script>
<script src="https://cdnjs.cloudflare.com/ajax/libs/d3-legend/2.25.6/d3-legend.js"></script>

<!-- Vue JS -->
<script src="https://cdn.jsdelivr.net/npm/vue/dist/vue.js"></script>

Expand All @@ -84,4 +79,4 @@
}
</script>
</body>
</html>
</html>
7 changes: 1 addition & 6 deletions examples/tests.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,11 +51,6 @@
<div id="legend"></div>
<div id="visualizer"></div>

<!-- D3, DagreD3 and D3 Legend -->
<script src="https://d3js.org/d3.v5.js"></script>
<script type="text/javascript" src="https://cdnjs.cloudflare.com/ajax/libs/dagre-d3/0.6.3/dagre-d3.min.js"></script>
<script src="https://cdnjs.cloudflare.com/ajax/libs/d3-legend/2.25.6/d3-legend.js"></script>

<!-- Vue JS -->
<script src="https://cdn.jsdelivr.net/npm/vue/dist/vue.js"></script>

Expand All @@ -68,4 +63,4 @@
};
</script>
</body>
</html>
</html>
Loading
Loading