Replace Travis CI with GitHub Actions #274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lfdebrux
force-pushed
the
ldeb-use-github-actions
branch
from
7975b6e to
05f7070
Compare
lfdebrux
force-pushed
the
ldeb-use-github-actions
branch
2 times, most recently
from
552c223 to
922744a
Compare
lfdebrux
force-pushed
the
ldeb-use-github-actions
branch
from
8d9447b to
cd2615d
Compare
lfdebrux
force-pushed
the
ldeb-use-github-actions
branch
from
cd2615d to
0fd04fe
Compare
lfdebrux
force-pushed
the
ldeb-use-github-actions
branch
from
0fd04fe to
565938b
Compare
lfdebrux
force-pushed
the
ldeb-use-github-actions
branch
from
565938b to
b6b3e19
Compare
We want to use GitHub Actions as the tech docs template's continuous integration/continuous deployment service. This commit removes `.travis.yml` and adds equivalent workflows, `test.yaml` and `publish.yaml`. The script to publish to RubyGems was copied from the discourse/publish-rubygems-action [[1]], with a modification to use the github-actions[bot] user for tagging the release following suggestion from fregante/setup-git-user action [[2]]. We avoid using the action directly in accordance with the guidelines in the GDS Way [[3]]. [1]: https://github.com/discourse/publish-rubygems-action/blob/b55d7b9/entrypoint.sh [2]: https://github.com/fregante/setup-git-user/blob/5ede2be/index.js [3]: https://gds-way.cloudapps.digital/standards/source-code.html#using-github-actions-and-workflows Use GitHub Actions bot account for creating release tags
We specify Node v14 in our `.nvmrc` file, which comes with npm v6. This version of npm complains when if finds a package-lock.json file using lockfileVersion@2, and replaces it with an equivalent lockfile using the older format. This is confusing for contributors, and breaks `rake release`, which complains about uncommited changes. This commit fixes the issue by commiting a version of package-lock.json using lockfileVersion@2. If and when this repo starts using Node v16 we can upgrade the lockfile again.
lfdebrux
force-pushed
the
ldeb-use-github-actions
branch
from
b6b3e19 to
bb5dd07
Compare
richardTowers
approved these changes
Oct 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to use GitHub Actions as the tech docs template's continuous integration/continuous deployment service. This commit removes
.travis.ymland adds equivalent workflows,test.yamlandpublish.yaml.The script to publish to RubyGems was copied from the cadwallion/publish-rubygems-action [1]. We avoid using the action directly in accordance with the guidelines in the GDS Way [2].
Once this PR is approved, we will need to change the branch protection rule required checks and add the RubyGems secrets to the rubygems environment in GitHub. We will also want to disconnect Travis from this repo.