Permit apostrophe in email address #1213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some email addresses contain an apostrophe in the person's name before the `@` symbol, but we are currently disallowing them. This adds that character into the validation for email addresses. Resolved https://govuk.zendesk.com/agent/tickets/5548904.
brucebolt
force-pushed
the
allow-apostrophe
branch
from
7f2c751 to
7338e20
Compare
AgaDufrat
approved these changes
Nov 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some email addresses contain an apostrophe in the person's name before the
@symbol, but we are currently disallowing them.This adds that character into the validation for email addresses.
Resolved https://govuk.zendesk.com/agent/tickets/5548904.
Follow these steps if you are doing a Rails upgrade.