filter_editions doesn't support multiple filters #3079
+1
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I added this "temporary" warning back in May last year, but I forgot to
make it an error until just now.
The code processing the filters is:
filters.each do |link_type, target_content_id|
scope = scope.where(links: { link_type:, target_content_id: })
end
... so the .where() statements would be ANDed together. If you provided
multiple different filters, you'd never get any results.
I've checked the logs in production, and my warning has not been served
in the last 14 days (our log retention), so I'm pretty confident it's
safe to tighten this up.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added this "temporary" warning back in May last year, but I forgot to make it an error until just now.
The code processing the filters is:
... so the .where() statements would be ANDed together. If you provided multiple different filters, you'd never get any results.
I've checked the logs in production, and my warning has not been served in the last 14 days (our log retention), so I'm pretty confident it's safe to tighten this up.
This application is owned by the publishing platform team. Please let us know in #govuk-publishing-platform when you raise any PRs.