497 edit page related external links

app/assets/javascripts/application.js

@@ -2,5 +2,6 @@
 
 //= require govuk_publishing_components/dependencies
 //= require govuk_publishing_components/lib
+//= require govuk_publishing_components/components/add-another
 //= require govuk_publishing_components/components/govspeak
 //= require govuk_publishing_components/components/table

app/assets/stylesheets/application.scss

@@ -4,6 +4,7 @@ $govuk-page-width: 1140px;
 @import 'govuk_publishing_components/govuk_frontend_support';
 @import 'govuk_publishing_components/component_support';
 @import 'govuk_publishing_components/components/button';
+@import 'govuk_publishing_components/components/add-another';
 @import 'govuk_publishing_components/components/checkboxes';
 @import 'govuk_publishing_components/components/date-input';
 @import 'govuk_publishing_components/components/details';

app/controllers/editions_controller.rb

@@ -83,6 +83,24 @@ def linking
     render action: "show"
   end
 
+  def update_related_external_links
+    artefact = resource.artefact
+
+    if params.key?("artefact")
+      artefact.assign_attributes(permitted_external_links_params)
+
+      if artefact.save
+        flash[:success] = "Related links updated."
+      else
+        flash[:danger] = artefact.errors.full_messages.join("\n")
+      end
+    else
+      flash[:danger] = "There aren't any external related links yet"
+    end
+
+    redirect_to related_external_links_edition_path(@resource.id)
+  end
+
   def confirm_unpublish
     if redirect_url.blank? || validate_redirect(redirect_url)
       render "secondary_nav_tabs/confirm_unpublish"
@@ -217,6 +235,10 @@ def permitted_update_params
     params.require(:edition).permit(%i[title overview in_beta body major_change change_note])
   end
 
+  def permitted_external_links_params
+    params.require(:artefact).permit(external_links_attributes: %i[title url id _destroy])
+  end
+
   def require_destroyable
     return if @resource.can_destroy?
 

app/helpers/tabbed_nav_helper.rb

@@ -23,6 +23,8 @@ def current_tab_name
       "unpublish"
     when "admin"
       "admin"
+    when "related_external_links"
+      "linking"
     else
       "temp_nav_text"
     end

app/views/editions/secondary_nav_tabs/_add-another_checkbox.html.erb

@@ -0,0 +1,5 @@
+<%= render "govuk_publishing_components/components/checkboxes", { 
+  name: "artefact[external_links_attributes][#{index}][_destroy]",
+  id: "artefact_external_links_attributes_#{index}__destroy",
+  items: [{label: "Delete", value: "1" }],
+} %>

app/views/editions/secondary_nav_tabs/_add-another_fieldset.html.erb

@@ -0,0 +1,24 @@
+<% if id %>
+  <%= hidden_field_tag "artefact[external_links_attributes][#{index}][id]", id %>
+<% end %>
+
+<%= render "govuk_publishing_components/components/input", {
+  label: {
+    text: "Title",
+    bold: true,
+  },
+  name: "artefact[external_links_attributes][#{index}][title]",
+  id: "artefact_external_links_attributes_#{index}_title",
+  value: @edition.artefact.external_links[index].present? ? @edition.artefact.external_links[index].title : "",
+} %>
+
+<%= render "govuk_publishing_components/components/input", {
+  label: {
+    text: "URL",
+    bold: true,
+  },
+  name: "artefact[external_links_attributes][#{index}][url]",
+  id: "artefact_external_links_attributes_#{index}_url",
+  value: @edition.artefact.external_links[index].present? ? @edition.artefact.external_links[index].url : "",
+  hint: "Example: https://gov.uk",
+} %>

app/views/editions/secondary_nav_tabs/_linking.html.erb

@@ -0,0 +1,40 @@
+<div class="govuk-grid-row">
+  <div class="govuk-grid-column-two-thirds">
+    <%= header_for("Related external links") %>
+
+    <%= form_for @edition.artefact, url: update_related_external_links_edition_path(@resource) do %>
+      <%
+        if @edition.artefact.external_links.count == 0
+          items = [{
+            fields: render(partial: "secondary_nav_tabs/add-another_fieldset", locals: { index: 0, id: nil }),
+            destroy_checkbox: render(partial: "secondary_nav_tabs/add-another_checkbox", locals: {index: 0}),
+          }]
+          empty = render(partial: "secondary_nav_tabs/add-another_fieldset", locals: { index: 1, id: nil })
+        else
+          items = @edition.artefact.external_links.each_with_index.map do | external_link, index |
+            {
+              fields: render(partial: "secondary_nav_tabs/add-another_fieldset", locals: { index:, id: external_link.id }),
+              destroy_checkbox: render(partial: "secondary_nav_tabs/add-another_checkbox", locals: {index: index}),
+            }
+          end
+          empty = render(partial: "secondary_nav_tabs/add-another_fieldset", locals: { index: @edition.artefact.external_links.count, id: nil })
+        end
+      %>
+
+      <%= render "govuk_publishing_components/components/add_another", {
+        fieldset_legend: "Link",
+        add_button_text: "Add another link",
+        items: items,
+        empty: empty,
+      } %>
+
+      <%= render "govuk_publishing_components/components/inset_text", {
+        text: "After saving, changes to related external links will be visible on the site the next time this publication is published.",
+      } %>
+
+      <%= render "govuk_publishing_components/components/button", {
+        text: "Save",
+      } %>
+    <% end %>
+  </div>
+</div>

config/routes.rb

@@ -24,6 +24,7 @@
         get "admin"
         post "duplicate"
         get "related_external_links", to: "editions#linking"
+        patch "update_related_external_links"
         get "tagging", to: "editions#linking"
         get "unpublish"
         get "unpublish/confirm-unpublish", to: "editions#confirm_unpublish", as: "confirm_unpublish"

test/functional/editions_controller_test.rb

@@ -625,6 +625,70 @@ class EditionsControllerTest < ActionController::TestCase
     end
   end
 
+  context "#update_related_external_links" do
+    should "display an error message when the title is blank" do
+      artefact = @edition.artefact
+
+      patch :update_related_external_links, params: {
+        id: @edition.id,
+        artefact: {
+          external_links_attributes: [{ title: "", url: "http://foo-bar.com", _destroy: false }],
+        },
+      }
+
+      artefact.reload
+
+      assert_equal "External links is invalid", flash[:danger]
+    end
+
+    should "display an error message when the url is blank" do
+      artefact = @edition.artefact
+
+      patch :update_related_external_links, params: {
+        id: @edition.id,
+        artefact: {
+          external_links_attributes: [{ title: "foo", url: "", _destroy: false }],
+        },
+      }
+
+      artefact.reload
+
+      assert_equal "External links is invalid", flash[:danger]
+    end
+
+    should "display an error message when the url is invalid" do
+      artefact = @edition.artefact
+
+      patch :update_related_external_links, params: {
+        id: @edition.id,
+        artefact: {
+          external_links_attributes: [{ title: "foo", url: "an-invalid-url", _destroy: false }],
+        },
+      }
+
+      artefact.reload
+
+      assert_equal "External links is invalid", flash[:danger]
+    end
+
+    should "update related external links and display a success message when succesfully saved" do
+      artefact = @edition.artefact
+
+      patch :update_related_external_links, params: {
+        id: @edition.id,
+        artefact: {
+          external_links_attributes: [{ title: "foo", url: "https://foo-bar.com", _destroy: false }],
+        },
+      }
+
+      artefact.reload
+
+      assert_equal "Related links updated.", flash[:success]
+      assert_equal "foo", artefact.external_links[0].title
+      assert_equal "https://foo-bar.com", artefact.external_links[0].url
+    end
+  end
+
 private
 
   def description(edition)