Bump non-SQLAlchemy dependencies to latest versions #4328
+52
−33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quis
force-pushed
the
bump-non-sqlalchemy-deps
branch
4 times, most recently
from
03080a4 to
2eca41c
Compare
The SQLAlchemy and it’s related dependencies have more breaking and interdependent changes which will take time to unpick. These changes are straightforward and don’t seem to break things. There are some changes to error messages from JSONSchema but these are ok because: - they’re only on our internal APIs - the admin app doesn’t seem to be parsing the content of these error messages: https://github.com/search?q=repo%3Aalphagov%2Fnotifications-admin%20%22is%20too%20short%22&type=code
quis
force-pushed
the
bump-non-sqlalchemy-deps
branch
from
2eca41c to
c62c65e
Compare
leohemsted
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SQLAlchemy and it’s related dependencies have more breaking and interdependent changes which will take time to unpick.
These changes are straightforward and don’t seem to break things.
There are some changes to error messages from JSONSchema but these are ok because: