Remove old build workflow and tidy up the new one. #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Made sense to keep this while we were switching to the new `build-multiarch.yml` workflow but now that the new thing is working, it's just mildly confusing having the old one lying around.
Just a bunch of small things: - Remove deleted branch from triggers. - Pick a start minute at random that's not too close to the hour (just to be nice and not bunch up with other people's jobs). - Move the build matrix config file out of the hidden .github directory, so nobody else has to waste time looking for it. - Just specify ubuntu-latest. We'd rather the build breaks because something needs updating to work with the latest supported OS (likely easy to fix) rather than it breaks because it got left on a pinned version until it went out of support (likely more effort to fix). - Remove `name` fields where they don't add anything beyond what's already in the `id` field. - Remove `id` fields where they're unused _and_ don't add any info beyond what's in the `uses` field. - Turn off logspew on `checkout` actions. (It's annoying this isn't the default, but hey.) - Clean up some spurious whitespace.
samsimpson1
approved these changes
Feb 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just small things, but:
namefields where they don't add anything beyond what's already in theidfield.idfields where they're unused and don't add any info beyond what's in theusesfield.checkoutactions. (It's annoying this isn't the default, but hey.)