Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert suspected-broken attempt to fix GitHub->ECR IAM authz. #1352

Merged
merged 3 commits into from
Jun 21, 2024
Merged

Revert suspected-broken attempt to fix GitHub->ECR IAM authz. #1352

merged 3 commits into from
Jun 21, 2024

Conversation

sengi
Copy link
Contributor

@sengi sengi commented Jun 20, 2024 •
edited
Loading

Reverts #1350, #1351, #1353.

Suspect those changes are why GitHub deploy.yml actions started failing like this:

Run aws-actions/configure-aws-credentials@v4
  with:
    role-to-assume: arn:aws:iam::17[2](https://github.com/alphagov/maslow/actions/runs/9601582713/job/26480461933#step:4:2)025368201:role/github_action_ecr_push
    aws-region: eu-west-1
    role-session-name: ecr-push
    audience: sts.amazonaws.com
Assuming role with OIDC
Assuming role with OIDC
Assuming role with OIDC
Assuming role with OIDC
Assuming role with OIDC
Assuming role with OIDC
Assuming role with OIDC
Assuming role with OIDC
Assuming role with OIDC
Assuming role with OIDC
Assuming role with OIDC
Assuming role with OIDC
Error: Could not assume role with OIDC: Not authorized to perform sts:AssumeRoleWithWebIdentity

@sengi sengi requested a review from samsimpson1 June 21, 2024 09:34
sengi added 3 commits June 21, 2024 10:56
@sengi
Revert "Merge pull request #1351 from alphagov/sengi/image-repos-not-…
d2e55f5 
…git-repos"

This reverts commit 757bbb7, reversing
changes made to f9eda9e.
@sengi
Revert "Merge pull request #1350 from alphagov/sengi/gh-topics-not-gr…
9d84fb6 
…eat-as-acls"

This reverts commit f9eda9e, reversing
changes made to bbb5757.
@sengi
Revert "Merge pull request #1353 from alphagov/sengi/ecr-push-role-name"
420c41a 
This reverts commit cb4cfb6, reversing
changes made to 757bbb7.
@sengi sengi force-pushed the sengi/revert-1350-1351 branch from 2bd5256 to 420c41a Compare June 21, 2024 09:56
@sengi sengi merged commit 06e0035 into main Jun 21, 2024
2 checks passed
@sengi sengi deleted the sengi/revert-1350-1351 branch June 21, 2024 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theseanything theseanything theseanything approved these changes

@samsimpson1 samsimpson1 Awaiting requested review from samsimpson1

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sengi @theseanything