Merge pull request #1373 from alphagov/add-pull-from-ecr-policy

Fix pull_from_ecr policy attachment for nodes
alphagov · Jul 8, 2024 · 1081dc9 · 1081dc9
2 parents f536f33 + 9d5f3b7
commit 1081dc9
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/terraform/deployments/cluster-infrastructure/main.tf b/terraform/deployments/cluster-infrastructure/main.tf
@@ -142,12 +142,16 @@ resource "aws_iam_policy" "pull_from_ecr" {
   policy      = data.aws_iam_policy_document.pull_from_ecr.json
 }
 
+resource "aws_iam_role_policy_attachment" "pull_from_ecr" {
+  policy_arn = aws_iam_policy.pull_from_ecr.arn
+  role       = aws_iam_role.node.name
+}
+
 resource "aws_iam_role_policy_attachment" "node" {
   for_each = toset([
     "AmazonEKSWorkerNodePolicy",
     "AmazonEKS_CNI_Policy",
     "AmazonSSMManagedInstanceCore",
-    aws_iam_policy.pull_from_ecr.name,
   ])
   policy_arn = "arn:aws:iam::aws:policy/${each.key}"
   role       = aws_iam_role.node.name