-
Notifications
You must be signed in to change notification settings - Fork 325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Workaround delays in ~/.npm
cache restore time
#4558
Conversation
Downgrades to v3 to avoid a bug in GitHub actions/cache actions/cache#810 Cache restore times for ~/.npm going over 5 minutes
📋 StatsFile sizes
Modules
View stats and visualisations on the review app Action run for 900c112 |
~/.npm
cache restore time~/.npm
cache restore time
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good to solve the issue, with install
running in a decent (for windows) time. 😄
It looks like we may be able to revert that PR at the next release of setup-node, though. I'll leave it with you to pick whether to merge then revert or hold for GitHub's next setup-node release (not sure of their lifecycle for that kind of things).
@romaricpascal Yeah spotted that today 🙌 After opening this PR I submitted feedback via a GitHub Actions survey and linked to a few issues Hopefully it all helped with the fix. I'll drop the Dependabot Update: I've confirmed the fix works via actions/setup-node#878 (comment) |
Now that Node.js 20 is available to local runners, we no longer need to agressively download the latest version on every run
4d7e1d0
to
900c112
Compare
Workaround delays in `~/.npm` cache restore time
We've seen 5+ minutes for Windows
~/.npm
cache restore since #4494 was mergedThis PR rolls back to
actions/[email protected]
actions/[email protected]
to avoid it:Node.js
keepAlive
defaultThe issue is caused by Node.js and fixed in
actions/cache
but needs anactions/setup-node
bumpThere was a similar fix for
ruby/setup-ruby
for more information