Replace organisation logos with metadata #3310
Conversation
This commit is a spike to explore how easy/hard it would be to replace organisation logos on HTML attachments with a call to the metadata component instead: https://components.publishing.service.gov.uk/component-guide/metadata#on_a_dark_background_without_padding Some organisations have custom logos, but we only display the logo if it will be the only logo on the page. If it will sit alongside other logos, we hide the custom logo. This behaviour is weird and unexpected.
| %> | ||
| <p class="publication-header__last-changed"><%= @content_item.last_changed %></p> | ||
| <% end %> | ||
| <div class="govuk-!-margin-top-5"> |
There was a problem hiding this comment.
Nice, I like the approach of using a utility class from the design system here, avoids adding custom CSS / stylesheet and easy to understand what it does just from looking at the view template 👍
There was a problem hiding this comment.
Just to provide some further info on this, I noticed a similar issue with spacing when reviewing another PR in government-frontend where we also use utility classes to apply spacing to each view template - #3338
After further investigation I think we can make an improvement in government-frontend by adding a CSS class to the main element as recommend by the page layout section of the design system. I have created a Trello card with further info on this and added it to the backlog - https://trello.com/c/Gawqbmsl/1307-page-layout-in-government-frontend-does-not-follow-the-design-system-guidance
This commit is a spike to explore how easy/hard it would be to replace organisation logos on HTML attachments with a call to the metadata component instead:
https://components.publishing.service.gov.uk/component-guide/metadata#on_a_dark_background_without_padding
Some organisations have custom logos, but we only display the logo if it will be the only logo on the page. If it will sit alongside other logos, we hide the custom logo. This behaviour is weird and unexpected.
Live site
Review app
Follow these steps if you are doing a Rails upgrade.
Trello: https://trello.com/c/3jez4Zg9/2799-understand-technical-design-and-content-implications-of-removing-org-logos-from-html-attachments