Skip to content

Commit

Permalink
Merge pull request #4522 from alphagov/fix-sass-deprecations
Browse files Browse the repository at this point in the history
Fix Sass Deprecations
  • Loading branch information
KludgeKML authored Dec 11, 2024
2 parents 4d41494 + 6a50866 commit cf9996e
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 11 deletions.
16 changes: 8 additions & 8 deletions app/assets/stylesheets/helpers/_parts.scss
Original file line number Diff line number Diff line change
Expand Up @@ -3,28 +3,28 @@
margin-top: govuk-spacing(6);
margin-bottom: govuk-spacing(6);
padding-bottom: govuk-spacing(3);

border-bottom: 1px solid govuk-colour("mid-grey");

@include govuk-media-query($from: tablet) {
margin-top: 0;
margin-bottom: 0;
}

border-bottom: 1px solid govuk-colour("mid-grey");
}

.part-navigation {
margin-left: 0;

@include govuk-media-query($until: tablet) {
margin-left: govuk-spacing(1);
}
}

.part-title {
@include govuk-font(27, $weight: bold);
margin-bottom: govuk-spacing(3);
margin-top: govuk-spacing(3);


@include govuk-font(27, $weight: bold);

@include govuk-media-query($from: tablet) {
margin-bottom: govuk-spacing(4);
margin-top: govuk-spacing(4);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@
.app-b-main-nav__button {
height: 70px;
color: govuk-colour("blue");
@include govuk-font(19);
background: none;
border: 0;
padding-left: govuk-spacing(3);
Expand All @@ -33,6 +32,7 @@
border-right: 1px solid govuk-colour("light-grey");
cursor: pointer;
position: relative;
@include govuk-font(19);
}

// Shared styles for the expanded and collapsed arrow icon. Based off of the super navigation menu button.
Expand Down
3 changes: 1 addition & 2 deletions app/assets/stylesheets/views/_travel-advice.scss
Original file line number Diff line number Diff line change
Expand Up @@ -85,9 +85,8 @@
// TODO: Remove this when components can accept variable unidirectional spacing,
// the component above should have a bigger margin-bottom.
.map {
@include responsive-bottom-margin;

margin-top: govuk-spacing(6);
@include responsive-bottom-margin;

.map-image {
max-width: 100%;
Expand Down

0 comments on commit cf9996e

Please sign in to comment.