Merge pull request #692 from alphagov/dependabot/bundler/rubocop-govu…

…k-4.13.0 Bump rubocop-govuk from 4.12.0 to 4.13.0
alphagov · Jan 15, 2024 · c6360ac · c6360ac
2 parents d77aef7 + cc829e1
commit c6360ac
Show file tree

Hide file tree

Showing 4 changed files with 25 additions and 23 deletions.
diff --git a/.gitignore b/.gitignore
@@ -1,2 +1,3 @@
 log
 coverage
+tmp
diff --git a/Gemfile.lock b/Gemfile.lock
@@ -90,7 +90,7 @@ GEM
     irb (1.11.0)
       rdoc
       reline (>= 0.3.8)
-    json (2.6.3)
+    json (2.7.1)
     json-schema (4.1.1)
       addressable (>= 2.8)
     language_server-protocol (3.17.0.3)
@@ -315,8 +315,8 @@ GEM
       opentelemetry-semantic_conventions
     opentelemetry-semantic_conventions (1.10.0)
       opentelemetry-api (~> 1.0)
-    parallel (1.23.0)
-    parser (3.2.2.3)
+    parallel (1.24.0)
+    parser (3.3.0.2)
       ast (~> 2.4.1)
       racc
     plek (5.0.0)
@@ -370,7 +370,7 @@ GEM
       connection_pool
     redis-namespace (1.11.0)
       redis (>= 4)
-    regexp_parser (2.8.1)
+    regexp_parser (2.9.0)
     reline (0.4.1)
       io-console (~> 0.5)
     request_store (1.5.1)
@@ -390,37 +390,38 @@ GEM
       diff-lcs (>= 1.2.0, < 2.0)
       rspec-support (~> 3.12.0)
     rspec-support (3.12.1)
-    rubocop (1.55.0)
+    rubocop (1.59.0)
       json (~> 2.3)
       language_server-protocol (>= 3.17.0)
       parallel (~> 1.10)
-      parser (>= 3.2.2.3)
+      parser (>= 3.2.2.4)
       rainbow (>= 2.2.2, < 4.0)
       regexp_parser (>= 1.8, < 3.0)
       rexml (>= 3.2.5, < 4.0)
-      rubocop-ast (>= 1.28.1, < 2.0)
+      rubocop-ast (>= 1.30.0, < 2.0)
       ruby-progressbar (~> 1.7)
       unicode-display_width (>= 2.4.0, < 3.0)
-    rubocop-ast (1.29.0)
+    rubocop-ast (1.30.0)
       parser (>= 3.2.1.0)
-    rubocop-capybara (2.18.0)
+    rubocop-capybara (2.20.0)
       rubocop (~> 1.41)
-    rubocop-factory_bot (2.23.1)
-      rubocop (~> 1.33)
-    rubocop-govuk (4.12.0)
-      rubocop (= 1.55.0)
-      rubocop-ast (= 1.29.0)
-      rubocop-rails (= 2.20.2)
+    rubocop-factory_bot (2.25.1)
+      rubocop (~> 1.41)
+    rubocop-govuk (4.13.0)
+      rubocop (= 1.59.0)
+      rubocop-ast (= 1.30.0)
+      rubocop-rails (= 2.23.0)
       rubocop-rake (= 0.6.0)
-      rubocop-rspec (= 2.22.0)
-    rubocop-rails (2.20.2)
+      rubocop-rspec (= 2.25.0)
+    rubocop-rails (2.23.0)
       activesupport (>= 4.2.0)
       rack (>= 1.1)
       rubocop (>= 1.33.0, < 2.0)
+      rubocop-ast (>= 1.30.0, < 2.0)
     rubocop-rake (0.6.0)
       rubocop (~> 1.0)
-    rubocop-rspec (2.22.0)
-      rubocop (~> 1.33)
+    rubocop-rspec (2.25.0)
+      rubocop (~> 1.40)
       rubocop-capybara (~> 2.17)
       rubocop-factory_bot (~> 2.22)
     ruby-progressbar (1.13.0)
@@ -447,7 +448,7 @@ GEM
       concurrent-ruby (~> 1.0)
     tzinfo-data (1.2023.4)
       tzinfo (>= 1.0.0)
-    unicode-display_width (2.4.2)
+    unicode-display_width (2.5.0)
     uuidtools (2.2.0)
     webmock (3.19.1)
       addressable (>= 2.8.0)

diff --git a/email_alert_service/models/change_history.rb b/email_alert_service/models/change_history.rb
@@ -6,7 +6,7 @@ def initialize(history:)
   end
 
   def latest_change_note
-    change_note = history&.sort_by { |note| note["public_timestamp"] }&.last
+    change_note = history&.max_by { |note| note["public_timestamp"] }
     change_note["note"] if change_note
   end
 end
diff --git a/spec/models/change_history_spec.rb b/spec/models/change_history_spec.rb
@@ -31,11 +31,11 @@
         ChangeHistory.new(
           history: [
             {
-              "public_timestamp": "2017-10-18T16:09:23.000+01:00",
+              "public_timestamp" => "2017-10-18T16:09:23.000+01:00",
               "note" => "a different change note",
             },
             {
-              "public_timestamp": "2017-10-19T16:09:23.000+01:00",
+              "public_timestamp" => "2017-10-19T16:09:23.000+01:00",
               "note" => "latest change note",
             },
           ],