Simplify One Login interstitial page #1630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jon-kirwan
reviewed
Oct 9, 2023
KludgeKML
force-pushed
the
update-one-login-message
branch
from
3df3539 to
82333ae
Compare
Oh, yes definitely. I suspect that that paragraph once upon a time had something complicated in it that meant it could only be HTML, but it definitely doesn't need to have it now. |
matthillco
approved these changes
Oct 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplify the interstitial page that comes when a user comes via the single-page-notification-button path and is required to create/use a One Login account.
https://trello.com/c/yxBLErqj/2135-improve-account-journeys-in-email-alert-frontend
BEFORE:
AFTER: