Update dataset page markup for the timeseries partial #833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owenatgov
force-pushed
the
dataset-page-timeseries-data
branch
from
1ee15a1 to
c818fc7
Compare
owenatgov
force-pushed
the
dataset-page-timeseries-data
branch
from
c818fc7 to
0e2329e
Compare
owenatgov
force-pushed
the
dataset-page-timeseries-data
branch
from
0e2329e to
7277205
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Update the markup, classnames and styling on the individual dataset view timeseries partial.
Why
DGU Find is currently using govuk elements, an outdated implementation of the govuk design system. This PR is one of several that attempts to slowly remove the elements implementation and replace it with up to date implementations from govuk frontend and govuk publishing components.
This PR was created as part of an effort to break down the existing dataset view PR which had grown too large to safely review in one go as it contains a large number of individual features.
Visual changes
TBC
Card: https://trello.com/c/h0XbWxq8/233-update-markup-on-find-dataset-page