-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump govuk_publishing_components from 39.2.4 to 41.0.0 #1439
Merged
andysellick
merged 1 commit into
main
from
dependabot/bundler/govuk_publishing_components-41.0.0
Jul 30, 2024
Merged
Bump govuk_publishing_components from 39.2.4 to 41.0.0 #1439
andysellick
merged 1 commit into
main
from
dependabot/bundler/govuk_publishing_components-41.0.0
Jul 30, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [govuk_publishing_components](https://github.com/alphagov/govuk_publishing_components) from 39.2.4 to 41.0.0. - [Changelog](https://github.com/alphagov/govuk_publishing_components/blob/main/CHANGELOG.md) - [Commits](alphagov/govuk_publishing_components@v39.2.4...v41.0.0) --- updated-dependencies: - dependency-name: govuk_publishing_components dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
|
andysellick
approved these changes
Jul 30, 2024
andysellick
deleted the
dependabot/bundler/govuk_publishing_components-41.0.0
branch
July 30, 2024 16:49
ChrisBAshton
added a commit
that referenced
this pull request
Sep 10, 2024
Despite the tests passing in #1439, the deployment failed in https://github.com/alphagov/contacts-admin/actions/runs/10166486149 with: ``` ``` Reverting so that deployment works again as normal, and we can investigate bumping govuk_publishing_components again later.
ChrisBAshton
added a commit
that referenced
this pull request
Sep 10, 2024
Despite the tests passing in #1439, the deployment failed in https://github.com/alphagov/contacts-admin/actions/runs/10166486149 with: ``` [builder 7/7] RUN rails assets:precompile && rm -fr log 0.106 INFO: with_tmpdir_for_ruby: execing rails with TMPDIR=/tmp/ruby-app-xGCNAKnA 1.525 I, [2024-07-30T17:53:13.769638 #7] INFO -- : govuk_app_config changing time_zone from UTC (the default) to London 10.13 bin/rails aborted! 10.13 Uglifier::Error: Name expected (Uglifier::Error) 10.13 -- 10.13 33111 window.GOVUK.modules.start() 10.13 33112 }); 10.13 33113 (function (global, factory) { 10.13 33114 typeof exports === 'object' && typeof module !== 'undefined' ? factory(exports) : 10.13 33115 typeof define === 'function' && define.amd ? define(['exports'], factory) : 10.13 33116 (global = typeof globalThis !== 'undefined' ? globalThis : global || self, factory(global.GOVUKFrontend = {})); 10.13 33117 })(this, (function (exports) { 'use strict'; 10.13 33118 10.13 => function mergeConfigs(...configObjects) { ``` Reverting so that deployment works again as normal, and we can investigate bumping govuk_publishing_components again later.
ChrisBAshton
added a commit
that referenced
this pull request
Sep 17, 2024
Despite the tests passing in #1439, the deployment failed in https://github.com/alphagov/contacts-admin/actions/runs/10166486149 with: ``` [builder 7/7] RUN rails assets:precompile && rm -fr log 0.106 INFO: with_tmpdir_for_ruby: execing rails with TMPDIR=/tmp/ruby-app-xGCNAKnA 1.525 I, [2024-07-30T17:53:13.769638 #7] INFO -- : govuk_app_config changing time_zone from UTC (the default) to London 10.13 bin/rails aborted! 10.13 Uglifier::Error: Name expected (Uglifier::Error) 10.13 -- 10.13 33111 window.GOVUK.modules.start() 10.13 33112 }); 10.13 33113 (function (global, factory) { 10.13 33114 typeof exports === 'object' && typeof module !== 'undefined' ? factory(exports) : 10.13 33115 typeof define === 'function' && define.amd ? define(['exports'], factory) : 10.13 33116 (global = typeof globalThis !== 'undefined' ? globalThis : global || self, factory(global.GOVUKFrontend = {})); 10.13 33117 })(this, (function (exports) { 'use strict'; 10.13 33118 10.13 => function mergeConfigs(...configObjects) { ``` Reverting so that deployment works again as normal, and we can investigate bumping govuk_publishing_components again later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps govuk_publishing_components from 39.2.4 to 41.0.0.
Changelog
Sourced from govuk_publishing_components's changelog.
Commits
19aecf2
Merge pull request #4121 from alphagov/version-41.0.059229ab
Version 41.0.0a41fb1d
Merge pull request #4068 from alphagov/remove-ua9dd8c49
Update changelogc196da4
Remove main UA codeb15181f
Remove misc UA references8e0381e
Remove UA from cross service header650a058
Remove UA from toggle95a57c1
Remove UA from cookie functions code57d0f01
Remove UA from cookie settings codeDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditions
will show all of the ignore conditions of the specified dependency@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)