Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[on hold] HEP dimuon example #201

Draft
wants to merge 8 commits into
base: develop
Choose a base branch
from

Conversation

bernhardmgruber
Copy link
Member

No description provided.

@bussmann
Copy link

I'm sorry, but what is HEP? What is dimuon? You should strongly reconsider your strategy on issue documentation. In the long run, your strategy of minimal doc + assumed self documentation will hurt the adaption of LLAMA by users as it does not instill confidence in understanding what is going on by outsiders. There are well-established guidelines for this and they come from a long standing expertise. Trust them.

@bernhardmgruber
Copy link
Member Author

but what is HEP? What is dimuon?

HEP = High Energy Physics
dimuon = a system containing two muons

You should strongly reconsider your strategy on issue documentation. In the long run, your strategy of minimal doc + assumed self documentation will hurt the adaption of LLAMA by users as it does not instill confidence in understanding what is going on by outsiders. There are well-established guidelines for this and they come from a long standing expertise. Trust them.

This is a draft pull request. It is marked as draft because it is incomplete. This is not an issue. It does not describe a bug or a feature request needing details and rational. It is just a draft of a piece of code on public display that is intended to evolve. It is here so I can discuss this example with other people. Once it is finished, this PR and the example will get a better description, depending on where it goes.

* allow dynamic field types in the record dimension
* add specializations to most of the core functions
* add llama::dynamic to signal a dynamic array member in a RecordCoord
* extend VirtualRecord to allow holding dynamic indices
* extend blobNrAndOffset to allow for additional dynamic indices
* add OffsetTable mapping
* add customization allowing to dump OffsetTable mappings
* add a few unit tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants