Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #70 - Add no-store cache header to wp-login.php #71

Merged
merged 6 commits into from
Feb 2, 2024
Merged

Issue #70 - Add no-store cache header to wp-login.php #71

merged 6 commits into from
Feb 2, 2024

Conversation

anubisthejackle
Copy link
Contributor

@anubisthejackle anubisthejackle commented Jan 31, 2024 •
edited by jira bot
Loading

Summary

PEERS TECH - Alleyvate Issue #70

Notes for reviewers

None.

Other Information

  • I updated the README.md file for any new/updated features.
  • I updated the CHANGELOG.md file for any new/updated features.

Changelog entries

Added

Changed

Deprecated

Removed

Fixed

  • Addressed the issue described in TECH-17 where as a developer, I want to contribute to the technology department’s open source software or internal tooling.

Security

@anubisthejackle anubisthejackle marked this pull request as ready for review January 31, 2024 16:52
@anubisthejackle anubisthejackle requested a review from a team as a code owner January 31, 2024 16:52
srtfisher
srtfisher requested changes Jan 31, 2024
View reviewed changes
Copy link
Member

@srtfisher srtfisher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this make sense as a part of the login_nonce feature instead since the issue is caused by that feature?

if not, this will need a README and changelog addition. Also please update the PR title and description to be relevant to the issue being fixed.

@srtfisher srtfisher linked an issue Jan 31, 2024 that may be closed by this pull request
Bug: Login Nonce fails for pages "cached" by bfcache #70
Closed
@renatonascalves
Copy link
Contributor

I agree with Sean!

@anubisthejackle anubisthejackle changed the title TECH-17: PEERS TECH - Alleyvate Issue #70 Issue #70 - Add no-store cache header to wp-login.php Jan 31, 2024
srtfisher
srtfisher approved these changes Jan 31, 2024
View reviewed changes
Copy link
Member

@srtfisher srtfisher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great! just needs a changelog entry

@anubisthejackle anubisthejackle merged commit 3ecd425 into main Feb 2, 2024
9 checks passed
@anubisthejackle anubisthejackle deleted the feature/TECH-17/contribute-to-open-source branch February 2, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srtfisher srtfisher srtfisher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: Login Nonce fails for pages "cached" by bfcache
3 participants
@anubisthejackle @renatonascalves @srtfisher