Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Upgrading dependencies #58

Merged
merged 2 commits into from
Dec 7, 2023
Merged

Chore: Upgrading dependencies #58

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
625207e
Upgrading testkit to 0.12, coding standards to 2
srtfisher Dec 6, 2023
5a884e5
Upgrading coding standards, fixing external request
srtfisher Dec 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,9 +23,9 @@
"composer/installers": "^1.0"
},
"require-dev": {
"alleyinteractive/alley-coding-standards": "^1.0",
"alleyinteractive/alley-coding-standards": "^2.0",
"friendsofphp/php-cs-fixer": "^3.8",
"mantle-framework/testkit": "^0.11"
"mantle-framework/testkit": "^0.12"
},
"scripts": {
"fixer": "php-cs-fixer -v fix --allow-risky=yes",
Expand Down
1 change: 0 additions & 1 deletion src/alley/wp/alleyvate/features/class-disable-dashboard-widgets.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,5 +59,4 @@ public function action__disable_dashboard_widgets() {
remove_meta_box( $widget['id'], 'dashboard', $widget['context'] );
}
}

}
3 changes: 0 additions & 3 deletions tests/alley/wp/alleyvate/features/test-clean-admin-bar.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,6 @@ public function test_remove_admin_bar_nodes() {
foreach ( $disposable_nodes as $disposable_node ) {
$this->assertArrayNotHasKey( $disposable_node, $current_nodes, $disposable_node . ' should not exist in $wp_admin_bar global after boot.' );
}

}

/**
Expand Down Expand Up @@ -102,7 +101,6 @@ function ( $disposable_nodes ) use ( $node ) {
$current_nodes = $admin_bar->get_nodes();

$this->assertArrayNotHasKey( $node, $current_nodes, 'The filtered node ' . $node . ' should not exist in $wp_admin_bar global after boot.' );

}

/**
Expand All @@ -122,5 +120,4 @@ public function apply_admin_bar() {

return $wp_admin_bar;
}

}
4 changes: 2 additions & 2 deletions tests/alley/wp/alleyvate/features/test-disable-comments.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,8 @@
* Tests for fully disabling comment functionality.
*/
final class Test_Disable_Comments extends Test_Case {
use \Mantle\Testing\Concerns\Admin_Screen,
\Mantle\Testing\Concerns\Refresh_Database;
use \Mantle\Testing\Concerns\Admin_Screen;
use \Mantle\Testing\Concerns\Refresh_Database;

/**
* Feature instance.
Expand Down
3 changes: 3 additions & 0 deletions tests/alley/wp/alleyvate/features/test-disable-dashboard-widgets.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,9 @@ protected function setUp(): void {
parent::setUp();

$this->feature = new Disable_Dashboard_Widgets();

$this->prevent_stray_requests();
$this->fake_request();
}

/**
Expand Down
6 changes: 3 additions & 3 deletions tests/alley/wp/alleyvate/features/test-disable-sticky-posts.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,8 +44,8 @@ protected function setUp(): void {
*/
public function test_disable_sticky_posts_in_query() {

$posts = static::factory()->post->create_ordered_set( 5 );
$stick_post_id = static::factory()->post->create(
$posts = self::factory()->post->create_ordered_set( 5 );
$stick_post_id = self::factory()->post->create(
[
'post_date' => '2019-01-01 00:00:00',
]
Expand Down Expand Up @@ -90,7 +90,7 @@ public function test_disable_sticky_posts_in_query() {
public function test_disable_action_sticky_rest_api_edit() {
$this->acting_as( 'administrator' );

$post_id = static::factory()->post->create();
$post_id = self::factory()->post->create();

$this->get(
rest_url( 'wp/v2/posts/' . $post_id . '?context=edit' ),
Expand Down
Loading