disable Apple News pushes on non-production environments

[mogmarsh]

Summary

As titled.

Notes for reviewers

None.

Changelog entries

Added

Changed

Deprecated

Removed

Fixed

Security

[renatonascalves]

Left a few questions and suggestions. :)

[jakewrfoster]

@mogmarsh does this close #26 ?

[benpbolton]

Temporary review

Temporary review to clear #alley

[emilyatmobtown]

I'd recommend also disabling remote images when not on production. Otherwise, Apple News will trigger an error and fail the push if it tries to fetch remote images that it doesn't have access to, i.e. from local envs or protected non-production envs.

[mogmarsh]

@mogmarsh does this close #26 ?

it should

[mogmarsh]

I'd recommend also disabling remote images when not on production. Otherwise, Apple News will trigger an error and fail the push if it tries to fetch remote images that it doesn't have access to, i.e. from local envs or protected non-production envs.

this is disabling all pushes, so the image references won't matter.

[emilyatmobtown]

@mogmarsh Ah, right. I was thinking of scenarios in which we have test credentials on non-prod.

In that case, I'd suggest also disabling if WP_CLI is true. That will ensure that posts don't get pushed on batch updates via CLI in production.

[jakewrfoster]

@emilyatmobtown's input is valid, but should come in the form of a future issue and not block this one. I see preventing prod bulk CLI updates as a separate feature from blocking pushes on lower environments.

[mogmarsh]

@emilyatmobtown's input is valid, but should come in the form of a future issue and not block this one. I see preventing prod bulk CLI updates as a separate feature from blocking pushes on lower environments.

https://github.com/alleyinteractive/wp-bulk-task/blob/main/src/trait-bulk-task-side-effects.php also could handle this in many CLI situations if we use it.

Extensive revisions. New reviews required.

[srtfisher]

fwiw, mantle will set this as of v1.0.4: https://github.com/alleyinteractive/mantle-framework/blob/4961ae56da6464d0b4732f075ea8e9ca2b3e2d89/src/mantle/testing/wordpress-bootstrap.php#L106-L108

[anubisthejackle]

Interesting. It wasn't, which is why I had to add it here. Maybe worth a look?

[anubisthejackle]

Ohhh I missed the asof line. That's probably why.