Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue-95: force_two_factor_authentication feature causing 502 errors on VIP #100

Merged
merged 3 commits into from
Jul 22, 2024

Conversation

anubisthejackle
Copy link
Contributor

@anubisthejackle anubisthejackle commented Jul 22, 2024

Summary

As titled. Fixes #95

Notes for reviewers

None.

Other Information

  • I updated the README.md file for any new/updated features.
  • I updated the CHANGELOG.md file for any new/updated features.

Changelog entries

Added

Changed

Deprecated

Removed

Fixed

  • Fixed an issue where creating a new user without enabling two-factor authentication (2FA) led to a 502 nginx error on login. This was caused by an infinite loop in the Alleyvate plugin on WordPress VIP environments. The solution involves modifying the plugin's logic to prevent this loop.

Security

@anubisthejackle anubisthejackle marked this pull request as ready for review July 22, 2024 16:52
@anubisthejackle anubisthejackle requested a review from a team as a code owner July 22, 2024 16:52
Copy link
Member

@kevinfodness kevinfodness left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍣

@anubisthejackle anubisthejackle merged commit 1c694d5 into main Jul 22, 2024
7 checks passed
@anubisthejackle anubisthejackle deleted the fix/issue-95/force-2fa-causes-502-errors-vip branch July 22, 2024 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

force_two_factor_authentication feature causing 502 errors on VIP
2 participants