PHPCS

src/alley/wp/alleyvate/features/class-disable-login-cache.php

@@ -48,5 +48,4 @@ public function add_no_store_to_login( $headers ): array {
 
 		return $headers;
 	}
-
 }

tests/alley/wp/alleyvate/features/test-disable-login-cache.php

@@ -37,6 +37,13 @@ protected function setUp(): void {
 		$this->feature = new Disable_Login_Cache();
 	}
 
+	/**
+	 * Verify that the no-store flag is added to the login page.
+	 *
+	 * Note: `wp_get_nocache_headers()` is used by `nocache_headers()` which
+	 * in turn is called on `wp-login.php`. We call it directly here so
+	 * we can assert against an array instead of trying to send headers.
+	 */
 	public function test_login_page_cache_is_no_stored() {
 		global $pagenow;
 
@@ -46,10 +53,13 @@ public function test_login_page_cache_is_no_stored() {
 
 		$headers = \wp_get_nocache_headers();
 
-		self::assertArrayHasKey('Cache-Control', $headers);
-		self::assertStringContainsString( 'no-store', $headers['Cache-Control']);
+		self::assertArrayHasKey( 'Cache-Control', $headers );
+		self::assertStringContainsString( 'no-store', $headers['Cache-Control'] );
 	}
 
+	/**
+	 * Verify that the no-store flag isn't added to other pages.
+	 */
 	public function test_non_login_page_is_stored() {
 		global $pagenow;
 
@@ -59,8 +69,7 @@ public function test_non_login_page_is_stored() {
 
 		$headers = \wp_get_nocache_headers();
 
-		self::assertArrayHasKey('Cache-Control', $headers);
-		self::assertStringNotContainsString( 'no-store', $headers['Cache-Control']);
+		self::assertArrayHasKey( 'Cache-Control', $headers );
+		self::assertStringNotContainsString( 'no-store', $headers['Cache-Control'] );
 	}
-
 }