Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FST-250 bf build arguments validation #306

Merged
merged 1 commit into from
Jan 19, 2022

Conversation

artnowo-alle
Copy link
Contributor

@artnowo-alle artnowo-alle commented Jan 14, 2022

  • moved _valid_datetime to bigflow.commons as valid_datetime
  • shuffled activities order in bf build (was: package -> image -> dags, is: dags -> package -> image)
  • moved workflow loading in operate.build_dags before other activities
  • made build/build-dags commands fail when no workflows found for ALL/none workflow ID

bigflow/cli.py Outdated Show resolved Hide resolved
@anjensan anjensan self-requested a review January 14, 2022 15:26
bigflow/cli.py Outdated Show resolved Hide resolved
test/cli/test_cli.py Outdated Show resolved Hide resolved
bigflow/commons.py Outdated Show resolved Hide resolved
bigflow/cli.py Outdated Show resolved Hide resolved
bigflow/cli.py Outdated Show resolved Hide resolved
bigflow/cli.py Outdated Show resolved Hide resolved
bigflow/cli.py Outdated Show resolved Hide resolved
bigflow/cli.py Outdated Show resolved Hide resolved
test/cli/test_cli.py Outdated Show resolved Hide resolved
test/cli/test_cli.py Outdated Show resolved Hide resolved
test/cli/test_cli.py Outdated Show resolved Hide resolved
test/cli/test_cli.py Outdated Show resolved Hide resolved
test/cli/test_cli.py Outdated Show resolved Hide resolved
@artnowo-alle
Copy link
Contributor Author

Pushed WIP commit, most conversations resolved

bigflow/build/operate.py Outdated Show resolved Hide resolved
bigflow/commons.py Show resolved Hide resolved
bigflow/commons.py Outdated Show resolved Hide resolved
bigflow/workflows.py Outdated Show resolved Hide resolved
bigflow/workflows.py Outdated Show resolved Hide resolved
bigflow/workflows.py Outdated Show resolved Hide resolved
test/test_workflows.py Outdated Show resolved Hide resolved
bigflow/workflow.py Outdated Show resolved Hide resolved
bigflow/workflow.py Outdated Show resolved Hide resolved
bigflow/workflow.py Outdated Show resolved Hide resolved
@anjensan anjensan self-requested a review January 18, 2022 12:24
@artnowo-alle artnowo-alle force-pushed the FST-250-cli-build-args-validation branch from d8f42ec to 348d9ef Compare January 19, 2022 07:59
@artnowo-alle artnowo-alle merged commit 21520aa into master Jan 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants