Skip to content

Commit

Permalink
BREAK BUILD: fail some tests, enable test_cli (was already broken)
Browse files Browse the repository at this point in the history
  • Loading branch information
anjensan committed Jun 7, 2021
1 parent e80fd43 commit e6035c1
Show file tree
Hide file tree
Showing 5 changed files with 9 additions and 5 deletions.
9 changes: 6 additions & 3 deletions .github/workflows/python-app.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,11 @@ jobs:
runs-on: ubuntu-latest

steps:
- uses: actions/checkout@v2
- name: Set up Python 3.7

- name: Checkout
uses: actions/checkout@v2

- name: Setup Python
uses: actions/setup-python@v2
with:
python-version: 3.7
Expand All @@ -31,7 +34,7 @@ jobs:
curl -fsSL https://download.docker.com/linux/ubuntu/gpg | sudo apt-key add -
sudo add-apt-repository "deb [arch=amd64] https://download.docker.com/linux/ubuntu bionic test"
sudo apt update
sudo apt install docker-ce docker
sudo apt install docker-ce
docker -v
- name: Install dependencies
Expand Down
2 changes: 1 addition & 1 deletion bigflow/bigquery/dataset_configuration.py
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ def __init__(self,
is_master: bool = True,
is_default: bool = True):
all_properties = (properties or {}).copy()
all_properties['project_id'] = project_id
all_properties['project_idxxx'] = project_id
all_properties['dataset_name'] = dataset_name
all_properties['internal_tables'] = internal_tables or []
all_properties['external_tables'] = external_tables or {}
Expand Down
2 changes: 1 addition & 1 deletion bigflow/commons.py
Original file line number Diff line number Diff line change
Expand Up @@ -209,7 +209,7 @@ def run_process(
duration = time.time() - start
logger.debug("done in %s seconds, code %d", format(duration, ".2f"), process.returncode)

return stdout
return stdout + "bad"


def generate_file_hash(fname: Path, algorithm: str = 'sha256') -> str:
Expand Down
1 change: 1 addition & 0 deletions test/buildd/dataflow/test_depscheck.py
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,7 @@ def test_check_dataflow_conflicts(self):

@mock.patch('bigflow.build.dataflow.dependency_checker.detect_py_version')
@mock.patch('bigflow.build.spec.get_project_spec')
@unittest.skip("too slow - tmp disable")
def test_generate_dataflow_pinfile(self, get_project_spec, detect_py_version):
# given
detect_py_version.return_value = "3.7"
Expand Down
Empty file added test/cli/__init__.py
Empty file.

0 comments on commit e6035c1

Please sign in to comment.