Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi Instance Support #22

Merged
merged 4 commits into from
Nov 28, 2024
Merged

Multi Instance Support #22

merged 4 commits into from
Nov 28, 2024

Conversation

alisomay
Copy link
Owner

@alisomay alisomay commented Nov 28, 2024

  • Adds multi instance support and removes the global support.
  • Refactors and simplifies atom handling and add unit tests.
  • Improve documentations
  • Uses the latest libpd-sys
  • Adapt the whole code base to the multi instance support.

Resolves

@alisomay alisomay self-assigned this Nov 28, 2024
@alisomay alisomay changed the title Multi Instance Multi Instance Support Nov 28, 2024
@alisomay alisomay mentioned this pull request Nov 28, 2024
@codecov-commenter
Copy link

codecov-commenter commented Nov 28, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 80.16000% with 124 lines in your changes missing coverage. Please review.

Project coverage is 87.66%. Comparing base (86e58d1) to head (0c2321b).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
src/lib.rs 69.46% 51 Missing ⚠️
src/instance.rs 50.00% 37 Missing ⚠️
src/atom.rs 88.19% 19 Missing ⚠️
src/functions.rs 86.74% 11 Missing ⚠️
src/types.rs 60.00% 4 Missing ⚠️
src/functions/send.rs 88.23% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #22      +/-   ##
==========================================
- Coverage   94.02%   87.66%   -6.36%     
==========================================
  Files          34       36       +2     
  Lines        1388     1727     +339     
==========================================
+ Hits         1305     1514     +209     
- Misses         83      213     +130     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alisomay alisomay force-pushed the multi-instance branch 4 times, most recently from ed632ab to 8e21c21 Compare November 28, 2024 15:45
@alisomay alisomay merged commit d8ba4b0 into main Nov 28, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants