network: handle empty wsPeer supplied to transaction handler #6193
+124
−12
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
There is a race between pubsub new peer discovery and wsPeer registration:
Suggested fix is to use
gsPeer
temporary type good enough for tx handler, and delay its resolution to wsPeer.Test Plan
Added a test confirming a closer set by ERL to a temporary peer is propagated to a wsPeer.