Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eval: do not disassemble failed app transaction #6170

Merged
merged 2 commits into from
Nov 14, 2024
Merged

eval: do not disassemble failed app transaction #6170

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1928d66
do not dissassemble failed txns
algorandskiy Nov 14, 2024
9e3453e
fix ledger app tests
algorandskiy Nov 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions data/transactions/logic/eval.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1027,8 +1027,8 @@ func (err EvalError) Unwrap() error {
}

func (cx *EvalContext) evalError(err error) error {
pc, det := cx.pcDetails()
details := fmt.Sprintf("pc=%d, opcodes=%s", pc, det)
pc := cx.pc
details := fmt.Sprintf("pc=%d", pc)

err = basics.Annotate(err,
"pc", pc,
Expand Down
2 changes: 1 addition & 1 deletion data/transactions/logic/evalStateful_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -929,7 +929,7 @@ itxn_submit
Stack: []any{uint64(777)},
},
},
"inner-msg": "logic eval error: cannot compare (uint64 to []byte). Details: app=5000, pc=26, opcodes=pushint 100; pushbytes 0x0201 // 0x0201; ==",
"inner-msg": "logic eval error: cannot compare (uint64 to []byte). Details: app=5000, pc=26",
"inner-attrs": map[string]any{
"pc": 26,
"group-index": 0,
Expand Down
Loading