cleanup: Use Go 1.19 atomic types #12104
ohillreviewdog.yml
on: pull_request
reviewdog-errors
7m 38s
reviewdog-warnings
4m 35s
Annotations
10 errors
|
reviewdog-errors:
catchup/catchpointService.go#L1
[Lint Errors] reported by reviewdog 🐶
: # github.com/algorand/go-algorand/catchup [github.com/algorand/go-algorand/catchup.test]
Raw Output:
catchup/catchpointService.go:1: : # github.com/algorand/go-algorand/catchup [github.com/algorand/go-algorand/catchup.test]
|
|
reviewdog-errors:
catchup/service_test.go#L24
[Lint Errors] reported by reviewdog 🐶
"sync/atomic" imported and not used (typecheck)
Raw Output:
catchup/service_test.go:24:2: "sync/atomic" imported and not used (typecheck)
// Copyright (C) 2019-2023 Algorand, Inc.
|
|
reviewdog-errors:
rpcs/blockService_test.go#L455
[Lint Errors] reported by reviewdog 🐶
copylocks: call of require.Zero copies lock value: sync/atomic.Uint64 contains sync/atomic.noCopy (govet)
Raw Output:
rpcs/blockService_test.go:455:18: copylocks: call of require.Zero copies lock value: sync/atomic.Uint64 contains sync/atomic.noCopy (govet)
require.Zero(t, bs1.wsMemoryUsed)
^
|
|
reviewdog-errors:
rpcs/blockService_test.go#L463
[Lint Errors] reported by reviewdog 🐶
copylocks: call of require.Positive copies lock value: sync/atomic.Uint64 contains sync/atomic.noCopy (govet)
Raw Output:
rpcs/blockService_test.go:463:22: copylocks: call of require.Positive copies lock value: sync/atomic.Uint64 contains sync/atomic.noCopy (govet)
require.Positive(t, bs1.wsMemoryUsed)
^
|
|
reviewdog-errors:
rpcs/blockService_test.go#L477
[Lint Errors] reported by reviewdog 🐶
copylocks: call of require.Zero copies lock value: sync/atomic.Uint64 contains sync/atomic.noCopy (govet)
Raw Output:
rpcs/blockService_test.go:477:18: copylocks: call of require.Zero copies lock value: sync/atomic.Uint64 contains sync/atomic.noCopy (govet)
require.Zero(t, bs1.wsMemoryUsed)
^
|
|
reviewdog-errors:
rpcs/ledgerService_test.go#L85
[Lint Errors] reported by reviewdog 🐶
copylocks: call of require.Equal copies lock value: sync/atomic.Int32 contains sync/atomic.noCopy (govet)
Raw Output:
rpcs/ledgerService_test.go:85:29: copylocks: call of require.Equal copies lock value: sync/atomic.Int32 contains sync/atomic.noCopy (govet)
require.Equal(t, int32(0), ledgerService.running)
^
|
|
reviewdog-errors:
rpcs/ledgerService_test.go#L100
[Lint Errors] reported by reviewdog 🐶
copylocks: call of require.Equal copies lock value: sync/atomic.Int32 contains sync/atomic.noCopy (govet)
Raw Output:
rpcs/ledgerService_test.go:100:29: copylocks: call of require.Equal copies lock value: sync/atomic.Int32 contains sync/atomic.noCopy (govet)
require.Equal(t, int32(1), ledgerService.running)
^
|
|
reviewdog-errors:
rpcs/ledgerService_test.go#L173
[Lint Errors] reported by reviewdog 🐶
copylocks: call of require.Equal copies lock value: sync/atomic.Int32 contains sync/atomic.noCopy (govet)
Raw Output:
rpcs/ledgerService_test.go:173:29: copylocks: call of require.Equal copies lock value: sync/atomic.Int32 contains sync/atomic.noCopy (govet)
require.Equal(t, int32(0), ledgerService.running)
^
|
|
reviewdog-errors:
shared/pingpong/pingpong.go#L121
[Lint Errors] reported by reviewdog 🐶
copylocks: call of fmt.Fprintf copies lock value: sync/atomic.Uint64 contains sync/atomic.noCopy (govet)
Raw Output:
shared/pingpong/pingpong.go:121:45: copylocks: call of fmt.Fprintf copies lock value: sync/atomic.Uint64 contains sync/atomic.noCopy (govet)
fmt.Fprintf(&ow, "%s %d", ppa.pk.String(), ppa.balance)
^
|
|
reviewdog-errors
reviewdog exited with status code: 1
|