Testing: Move WaitForConfirmedTxn down into clients #13892
jannottireviewdog.yml
on: pull_request
reviewdog-errors
1m 59s
reviewdog-warnings
1m 58s
reviewdog-shellcheck
15s
Annotations
2 errors and 3 warnings
|
reviewdog-errors:
libgoal/transactions.go#L210
[Lint Errors] reported by reviewdog 🐶
exported: comment on exported method Client.WaitForConfirmedTxn should be of the form "WaitForConfirmedTxn ..." (revive)
Raw Output:
libgoal/transactions.go:210:1: exported: comment on exported method Client.WaitForConfirmedTxn should be of the form "WaitForConfirmedTxn ..." (revive)
// WaitForRound takes a round, waits up to one minute, for it to appear and
^
|
|
reviewdog-errors
reviewdog exited with status code: 1
|
|
reviewdog-shellcheck
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
|
|
reviewdog-warnings
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
|
|
reviewdog-errors
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
|