Skip to content

catchpoints: more support for EnableOnlineAccountCatchpoints #13880

catchpoints: more support for EnableOnlineAccountCatchpoints

catchpoints: more support for EnableOnlineAccountCatchpoints #13880

Triggered via pull request January 3, 2025 06:15
Status Failure
Total duration 2m 5s
Artifacts

reviewdog.yml

on: pull_request
reviewdog-errors
1m 21s
reviewdog-errors
reviewdog-warnings
1m 56s
reviewdog-warnings
reviewdog-shellcheck
12s
reviewdog-shellcheck
Fit to window
Zoom out
Zoom in

Annotations

20 errors and 3 warnings
reviewdog-errors: cmd/catchpointdump/commands.go#L1
[Lint Errors] reported by reviewdog 🐶 : # github.com/algorand/go-algorand/cmd/catchpointdump Raw Output: cmd/catchpointdump/commands.go:1: : # github.com/algorand/go-algorand/cmd/catchpointdump
reviewdog-errors: cmd/catchpointdump/file.go#L597
[Lint Errors] reported by reviewdog 🐶 not enough arguments in call to sqlitedriver.MakeOnlineAccountsIter Raw Output: cmd/catchpointdump/file.go:597:61: not enough arguments in call to sqlitedriver.MakeOnlineAccountsIter have (context.Context, *sql.Tx, bool) want (context.Context, db.Queryable, bool, basics.Round)
reviewdog-errors: cmd/catchpointdump/file.go#L630
[Lint Errors] reported by reviewdog 🐶 not enough arguments in call to sqlitedriver.MakeOnlineRoundParamsIter Raw Output: cmd/catchpointdump/file.go:630:64: not enough arguments in call to sqlitedriver.MakeOnlineRoundParamsIter have (context.Context, *sql.Tx, bool) want (context.Context, db.Queryable, bool, basics.Round) (typecheck) // Copyright (C) 2019-2024 Algorand, Inc.
reviewdog-errors: ledger/store/trackerdb/dualdriver/accounts_reader.go#L1
[Lint Errors] reported by reviewdog 🐶 : # github.com/algorand/go-algorand/ledger/store/trackerdb/dualdriver Raw Output: ledger/store/trackerdb/dualdriver/accounts_reader.go:1: : # github.com/algorand/go-algorand/ledger/store/trackerdb/dualdriver
reviewdog-errors: ledger/store/trackerdb/dualdriver/dualdriver.go#L49
[Lint Errors] reported by reviewdog 🐶 cannot use &reader{…} (value of type *reader) as trackerdb.Reader value in struct literal: *reader does not implement trackerdb.Reader (wrong type for method MakeOnlineAccountsIter) Raw Output: ledger/store/trackerdb/dualdriver/dualdriver.go:49:43: cannot use &reader{…} (value of type *reader) as trackerdb.Reader value in struct literal: *reader does not implement trackerdb.Reader (wrong type for method MakeOnlineAccountsIter) have MakeOnlineAccountsIter(context.Context, bool) (trackerdb.TableIterator[*encoded.OnlineAccountRecordV6], error) want MakeOnlineAccountsIter(context.Context, bool, basics.Round) (trackerdb.TableIterator[*encoded.OnlineAccountRecordV6], error)
reviewdog-errors: ledger/store/trackerdb/dualdriver/dualdriver.go#L121
[Lint Errors] reported by reviewdog 🐶 cannot use &reader{…} (value of type *reader) as trackerdb.Reader value in struct literal: *reader does not implement trackerdb.Reader (wrong type for method MakeOnlineAccountsIter) Raw Output: ledger/store/trackerdb/dualdriver/dualdriver.go:121:39: cannot use &reader{…} (value of type *reader) as trackerdb.Reader value in struct literal: *reader does not implement trackerdb.Reader (wrong type for method MakeOnlineAccountsIter) have MakeOnlineAccountsIter(context.Context, bool) (trackerdb.TableIterator[*encoded.OnlineAccountRecordV6], error) want MakeOnlineAccountsIter(context.Context, bool, basics.Round) (trackerdb.TableIterator[*encoded.OnlineAccountRecordV6], error)
reviewdog-errors: ledger/store/trackerdb/dualdriver/dualdriver.go#L172
[Lint Errors] reported by reviewdog 🐶 cannot use &reader{…} (value of type *reader) as trackerdb.Reader value in struct literal: *reader does not implement trackerdb.Reader (wrong type for method MakeOnlineAccountsIter) Raw Output: ledger/store/trackerdb/dualdriver/dualdriver.go:172:42: cannot use &reader{…} (value of type *reader) as trackerdb.Reader value in struct literal: *reader does not implement trackerdb.Reader (wrong type for method MakeOnlineAccountsIter) have MakeOnlineAccountsIter(context.Context, bool) (trackerdb.TableIterator[*encoded.OnlineAccountRecordV6], error) want MakeOnlineAccountsIter(context.Context, bool, basics.Round) (trackerdb.TableIterator[*encoded.OnlineAccountRecordV6], error) (typecheck) // Copyright (C) 2019-2024 Algorand, Inc.
reviewdog-errors: ledger/store/trackerdb/testdb/testdb.go#L23
[Lint Errors] reported by reviewdog 🐶 could not import github.com/algorand/go-algorand/ledger/store/trackerdb/dualdriver (-: # github.com/algorand/go-algorand/ledger/store/trackerdb/dualdriver Raw Output: ledger/store/trackerdb/testdb/testdb.go:23:2: could not import github.com/algorand/go-algorand/ledger/store/trackerdb/dualdriver (-: # github.com/algorand/go-algorand/ledger/store/trackerdb/dualdriver
reviewdog-errors: ledger/store/trackerdb/dualdriver/dualdriver.go#L49
[Lint Errors] reported by reviewdog 🐶 cannot use &reader{…} (value of type *reader) as trackerdb.Reader value in struct literal: *reader does not implement trackerdb.Reader (wrong type for method MakeOnlineAccountsIter) Raw Output: ledger/store/trackerdb/dualdriver/dualdriver.go:49:43: cannot use &reader{…} (value of type *reader) as trackerdb.Reader value in struct literal: *reader does not implement trackerdb.Reader (wrong type for method MakeOnlineAccountsIter) have MakeOnlineAccountsIter(context.Context, bool) (trackerdb.TableIterator[*encoded.OnlineAccountRecordV6], error) want MakeOnlineAccountsIter(context.Context, bool, basics.Round) (trackerdb.TableIterator[*encoded.OnlineAccountRecordV6], error)
reviewdog-errors
reviewdog: Too many results (annotations) in diff. You may miss some annotations due to GitHub limitation for annotation created by logging command. Please check GitHub Actions log console to see all results. Limitation: - 10 warning annotations and 10 error annotations per step - 50 annotations per job (sum of annotations from all the steps) - 50 annotations per run (separate from the job annotations, these annotations aren't created by users) Source: https://github.com/orgs/community/discussions/26680#discussioncomment-3252835
reviewdog-warnings: cmd/catchpointdump/file.go#L597
not enough arguments in call to sqlitedriver.MakeOnlineAccountsIter
reviewdog-warnings: cmd/catchpointdump/file.go#L630
not enough arguments in call to sqlitedriver.MakeOnlineRoundParamsIter
reviewdog-warnings: ledger/catchpointfilewriter_test.go#L152
not enough arguments in call to makeCatchpointFileWriter
reviewdog-warnings: ledger/catchpointfilewriter_test.go#L267
not enough arguments in call to makeCatchpointFileWriter
reviewdog-warnings: ledger/catchpointfilewriter_test.go#L310
not enough arguments in call to makeCatchpointFileWriter
reviewdog-warnings: ledger/catchpointfilewriter_test.go#L443
not enough arguments in call to makeCatchpointFileWriter
reviewdog-warnings: ledger/catchpointfilewriter_test.go#L549
not enough arguments in call to makeCatchpointFileWriter
reviewdog-warnings: cmd/catchpointdump/file.go#L597
[Lint Warnings] reported by reviewdog 🐶 not enough arguments in call to sqlitedriver.MakeOnlineAccountsIter Raw Output: cmd/catchpointdump/file.go:597:61: not enough arguments in call to sqlitedriver.MakeOnlineAccountsIter have (context.Context, *sql.Tx, bool) want (context.Context, db.Queryable, bool, basics.Round)
reviewdog-warnings: cmd/catchpointdump/file.go#L630
[Lint Warnings] reported by reviewdog 🐶 not enough arguments in call to sqlitedriver.MakeOnlineRoundParamsIter Raw Output: cmd/catchpointdump/file.go:630:64: not enough arguments in call to sqlitedriver.MakeOnlineRoundParamsIter have (context.Context, *sql.Tx, bool) want (context.Context, db.Queryable, bool, basics.Round) (typecheck) // Copyright (C) 2019-2024 Algorand, Inc.
reviewdog-warnings: ledger/catchpointfilewriter_test.go#L152
[Lint Warnings] reported by reviewdog 🐶 not enough arguments in call to makeCatchpointFileWriter Raw Output: ledger/catchpointfilewriter_test.go:152:92: not enough arguments in call to makeCatchpointFileWriter have (context.Context, "github.com/algorand/go-algorand/config".ConsensusParams, string, trackerdb.TransactionScope, number) want (context.Context, "github.com/algorand/go-algorand/config".ConsensusParams, string, trackerdb.SnapshotScope, int, basics.Round)
reviewdog-shellcheck
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
reviewdog-errors
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
reviewdog-warnings
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636