feat(clients): endpoint level timeout part 2 #4318
Open
+461
−64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🪓 The generated code will be pushed at the end of the CI.Action triggered by commit Please do not push any generated code to this pull request. |
Fluf22
force-pushed
the
fix/endpoint-level-timeouts
branch
7 times, most recently
from
fae535d to
52dfa8f
Compare
Fluf22
force-pushed
the
fix/endpoint-level-timeouts
branch
from
52dfa8f to
3fb27f1
Compare
Fluf22
force-pushed
the
fix/endpoint-level-timeouts
branch
from
3fb27f1 to
1da1e81
Compare
Fluf22
force-pushed
the
fix/endpoint-level-timeouts
branch
from
9e7e6a9 to
e53bc13
Compare
|
After the next release, I will rebase this PR on main so the CI for Java 17 can pass |
Or you can add |
Yeah but it's not an urgent PR? I don't think it will be merged before next week, so let's wait? |
millotp
reviewed
Jan 10, 2025
| @@ -6,6 +6,7 @@ import {{invokerPackage}}.ApiClient; | |||
| import {{invokerPackage}}.config.ClientOptions; | |||
|
|
|||
| import com.fasterxml.jackson.core.type.TypeReference; | |||
| import org.jetbrains.annotations.Nullable; | |||
There was a problem hiding this comment.
we already use javax.annotations.Nonnull in this file
Suggested change
| import org.jetbrains.annotations.Nullable; | |
| import javax.annotations.Nullable; |
| @@ -32,4 +42,7 @@ public RequestOptions() | |||
| QueryParameters = new Dictionary<string, object>(); | |||
| Headers = new Dictionary<string, string>(); | |||
| } | |||
|
|
|||
| // overload + operator | |||
|
|
||
| @Override | ||
| public void execute(Template.Fragment fragment, Writer writer) throws IOException { | ||
| writer.write(Integer.toString(Integer.parseInt(fragment.execute()) / 1000)); |
There was a problem hiding this comment.
with this lambda, can you remove the logic in Timeouts.enrichBundle and move it to the mustache instead ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧭 What and Why
🎟 JIRA Ticket: DI-3322 & DI-3327 & DI-3328 & DI-3329 & DI-3330 & DI-3331 & DI-3332 & DI-3333 & DI-3382
Changes included:
🧪 Test