Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add warning log when exceeding max number of pairs #587

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+13 −0
Open

chore: add warning log when exceeding max number of pairs #587

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1ddfecf
Add warning log for max number of pairs
thomaseizinger Nov 13, 2024
4969144
Only log warning once per agent
thomaseizinger Nov 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/ice/agent.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -789,6 +789,12 @@ impl IceAgent {
//
// TODO: How does this work with trickle ice?
let max = self.max_candidate_pairs.unwrap_or(100);

let num_pairs = self.candidate_pairs.len();
if num_pairs > max {
warn!(%max, %num_pairs, "Exceeding max number of candidate pairs");
}

while self.candidate_pairs.len() > max {
let pair = self.candidate_pairs.pop();
debug!("Remove overflow pair {:?}", pair);
Expand Down
Loading