Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move openssl vendored featureflag to default #580

Merged
merged 1 commit into from
Oct 27, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,19 @@ exclude = ["/cargo_deny.sh", "/deny.toml", "/run-fuzz.sh"]
# MSRV
rust-version = "1.65"

# Notes on OpenSSL
# - Vendored (static link source build) ensures version consistency and easier
# to build but increases size.
# - Non-vendored (dynamic link) uses system libraries, reducing size but may
# cause compatibility issues.
# Choose based on security and footprint needs.
# For large deployments sharing OS images, OS updates can be easier for
# security patching than updating statically linked software.

[features]
default = ["openssl", "sha1"]
default = ["openssl", "vendored", "sha1"]
openssl = ["dep:openssl", "dep:openssl-sys", "dep:libc"]
vendored = ["openssl?/vendored"]

# Without the sha1 feature, str0m uses the openssl sha1 impl which is slower.
sha1 = ["dep:sha1"]
Expand All @@ -33,9 +43,7 @@ sctp-proto = "0.3.0"
combine = "4.6.6"

# Sadly no DTLS support in rustls.
# If you want to use a system provided openssl you can set env variable
# OPENSSL_NO_VENDOR=1 to override the feature flag vendored
openssl = { version = ">=0.10.66", features = ["vendored"], optional = true }
openssl = { version = ">=0.10.66", optional = true }
openssl-sys = { version = "0.9.80", optional = true }
libc = { version = "0.2", optional = true }

Expand Down
Loading