Skip to content

Commit

Permalink
all tests green except classic.filters
Browse files Browse the repository at this point in the history
  • Loading branch information
Lars-Erik Roald committed Jan 14, 2025
1 parent 7873f77 commit d50a05f
Show file tree
Hide file tree
Showing 4 changed files with 170 additions and 146 deletions.
2 changes: 1 addition & 1 deletion src/sap/mergeSql.js
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
const getSessionSingleton = require('../table/getSessionSingleton');
const quote = require('./quote');

function insertSql(table, row, options) {
const quote = getSessionSingleton('quote');
let columnNames = [];
let conflictColumnUpdateSql = '';
let values = [];
Expand Down
2 changes: 1 addition & 1 deletion src/table/column/json/formatOut.js
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ function formatOut(context, column, alias) {
if (formatColumn)
return formatColumn(column, alias);
else
return `${alias}.${quote(column._dbName)}`;
return `${alias}.${quote(context, column._dbName)}`;
}

module.exports = formatOut;
2 changes: 1 addition & 1 deletion src/table/rollback.js
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ function _rollback(context, e) {

if (e) {
if (e.message?.indexOf('ORA-01476: divisor is equal to zero') > -1)
return newThrow(new Error('Conflict when updating a column'), chain);
return newThrow(context, new Error('Conflict when updating a column'), chain);
let errors = e.message && e.message.split(conflictId) || [];
if (errors.length > 1) {
return newThrow(context, new Error(errors[1]), chain);
Expand Down
Loading

0 comments on commit d50a05f

Please sign in to comment.