[Feature] Added Check benchmark for healthy #1816
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexjustesen
requested changes
Nov 24, 2024
alexjustesen
changed the base branch from
main
to
refactor-benchmarking-results
alexjustesen
approved these changes
Nov 25, 2024
alexjustesen
merged commit fad7d20
into
alexjustesen:refactor-benchmarking-results
1 check passed
alexjustesen
added a commit
that referenced
this pull request
Nov 26, 2024
* [Feature] Added Check benchmark for healthy (#1816) * Add Check and update benchmarsk state process * Add helper and result resource * Add filter * Fix result table * replace placeholder * Use Helpers\Benchmark --------- Co-authored-by: Alex Justesen <[email protected]> * moved skipspeedtestjob to ookla namespace * consolidated benchmark jobs * fixed typo * benchmark helper should be truthy --------- Co-authored-by: Sven van Ginkel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📃 Description
This PR adds a benchmark checker, to check the results against set benchmark. Will add a
"passed":"true/false"to the json.{"download":{"bar":"min","type":"absolute","value":15,"unit":"mbps","passed":"true"},"upload":{"bar":"min","type":"absolute","value":15,"unit":"mbps","passed":"true"}}To close: #964
To close: #646
🪵 Changelog
➕ Added
CheckAndUpdateBenchmarkResultProcesshealthyinformation to the results screen.healthyto the filters📷 Screenshots