Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for latest clippy nightly #456

Merged
merged 3 commits into from
Apr 20, 2024
Merged

Fix for latest clippy nightly #456

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
020ca33
Fix for latest clippy nightly
alex Apr 19, 2024
395adb3
test coverage on beta
alex Apr 19, 2024
7de2fac
test coverage on 1.76
alex Apr 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ jobs:

- uses: dtolnay/rust-toolchain@1482605bfc5719782e1267fd0c0cc350fe7646b8
with:
toolchain: stable
toolchain: 1.76.0
components: llvm-tools-preview

- run: sudo apt update && sudo apt-get install -y lcov
Expand Down
9 changes: 3 additions & 6 deletions src/parser.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -768,10 +768,7 @@ mod tests {
(Ok(-128), b"\x02\x01\x80"),
(Ok(-129), b"\x02\x02\xff\x7f"),
(Ok(-256), b"\x02\x02\xff\x00"),
(
Ok(core::i64::MAX),
b"\x02\x08\x7f\xff\xff\xff\xff\xff\xff\xff",
),
(Ok(i64::MAX), b"\x02\x08\x7f\xff\xff\xff\xff\xff\xff\xff"),
(
Err(ParseError::new(ParseErrorKind::UnexpectedTag {
actual: Tag::primitive(0x3),
Expand Down Expand Up @@ -817,7 +814,7 @@ mod tests {
fn parse_int_u64() {
assert_parses::<u64>(&[
(
Ok(core::u64::MAX),
Ok(u64::MAX),
b"\x02\x09\x00\xff\xff\xff\xff\xff\xff\xff\xff",
),
(
Expand All @@ -841,7 +838,7 @@ mod tests {
(Ok(-128), b"\x02\x01\x80"),
(Ok(-129), b"\x02\x02\xff\x7f"),
(Ok(-256), b"\x02\x02\xff\x00"),
(Ok(core::i32::MAX), b"\x02\x04\x7f\xff\xff\xff"),
(Ok(i32::MAX), b"\x02\x04\x7f\xff\xff\xff"),
(
Err(ParseError::new(ParseErrorKind::UnexpectedTag {
actual: Tag::primitive(0x3),
Expand Down