tests(integration): add integration tests and test them with a pipeline #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ccoVeille
reviewed
Aug 8, 2024
…ted pipeline Signed-off-by: Alessio Greggi <[email protected]>
|
@ccoVeille I performed several changes to the code base, but finally there's a pipeline to test both unit and integration tests :) |
ccoVeille
reviewed
Aug 10, 2024
Co-authored-by: ccoVeille <[email protected]>
Co-authored-by: ccoVeille <[email protected]>
Co-authored-by: ccoVeille <[email protected]>
Co-authored-by: ccoVeille <[email protected]>
Co-authored-by: ccoVeille <[email protected]>
Signed-off-by: Alessio Greggi <[email protected]>
Signed-off-by: Alessio Greggi <[email protected]>
Signed-off-by: Alessio Greggi <[email protected]>
Signed-off-by: Alessio Greggi <[email protected]>
ccoVeille
reviewed
Aug 12, 2024
| @@ -20,7 +20,7 @@ import ( | |||
| "io" | |||
| "os" | |||
|
|
|||
| "github.com/alegrey91/harpoon/internal/captor" | |||
| "github.com/alegrey91/harpoon/internal/ebpf/probesfacade/captor" | |||
| meta "github.com/alegrey91/harpoon/internal/metadata" | |||
| "github.com/alegrey91/harpoon/internal/writer" | |||
| "github.com/spf13/cobra" | |||
There was a problem hiding this comment.
Cobra and yaml import should be before the packages of this module
| @@ -19,7 +19,7 @@ import ( | |||
| "fmt" | |||
| "strings" | |||
|
|
|||
| "github.com/alegrey91/harpoon/internal/captor" | |||
| "github.com/alegrey91/harpoon/internal/ebpf/probesfacade/captor" | |||
| "github.com/alegrey91/harpoon/internal/writer" | |||
| "github.com/spf13/cobra" | |||
There was a problem hiding this comment.
Cobra should be in a separate block before the packages of the module
There was a problem hiding this comment.
I think is better open another issue for refactoring all these things
There was a problem hiding this comment.
might be a good PR to fix all the errors reported by golangci-lint that you are going to add
Co-authored-by: ccoVeille <[email protected]>
Co-authored-by: ccoVeille <[email protected]>
Co-authored-by: ccoVeille <[email protected]>
ccoVeille
approved these changes
Aug 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #33