feat(rn): add alpha react native signer impl #1128

moldy530 · 2024-11-04T21:45:58Z

Pull Request Checklist

Did you add new tests and confirm existing tests pass? (yarn test)
Did you update relevant docs? (docs are found in the site folder, and guidelines for updating/adding docs can be found in the contribution guide)
Do your commits follow the Conventional Commits standard?
Does your PR title also follow the Conventional Commits standard?
If you have a breaking change, is it correctly reflected in your commit message? (e.g. feat!: breaking change)
Did you run lint (yarn lint:check) and fix any issues? (yarn lint:write)
Did you follow the contribution guidelines?

PR-Codex overview

This PR introduces significant updates to the @account-kit/react-native-signer library, including new configuration files, enhancements to the example app, and various adjustments for compatibility with React Native's new architecture.

Detailed summary

Added .watchmanconfig files to multiple directories.
Updated jest.config.js for testing configuration.
Enhanced babel.config.js for Babel presets.
Introduced new icons and splash screens for the example app.
Improved AndroidManifest.xml with permissions and configurations.
Updated AppDelegate and bridging files for iOS compatibility.
Added TurboModule support for improved performance.
Configured CI workflows for linting, testing, and building.
Enhanced the README with installation and usage instructions.
Added local storage polyfill in mmkv-localstorage-polyfill.ts.

The following files were skipped due to too many changes: account-kit/rn-signer/.github/workflows/ci.yml, account-kit/rn-signer/src/client.ts, account-kit/rn-signer/android/build.gradle, account-kit/rn-signer/example/ios/ReactNativeSignerExample/LaunchScreen.storyboard, account-kit/rn-signer/example/android/app/build.gradle, account-kit/rn-signer/android/src/main/java/com/accountkit/reactnativesigner/NativeTEKStamperModule.kt, account-kit/rn-signer/example/android/gradlew, account-kit/rn-signer/example/ios/ReactNativeSignerExample.xcodeproj/project.pbxproj, yarn.lock

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

vercel · 2024-11-04T21:45:59Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
aa-sdk-site	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Nov 15, 2024 10:56pm
aa-sdk-ui-demo	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Nov 15, 2024 10:56pm

moldy530 · 2024-11-04T21:46:12Z

feat(rn): add alpha react native signer impl #1128 : 2 dependent PRs (#1129 , #1134 ) 👈 (View in Graphite)
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

moldy530 · 2024-11-04T22:51:33Z

account-kit/rn-signer/.github/actions/setup/action.yml

this was auto-generated. I'll look to consolidate this file with the one we already have so we can make sure this and the one below run in CI correctly

moldy530 · 2024-11-04T22:52:07Z

account-kit/rn-signer/.github/workflows/ci.yml

This was also auto generated, I'll look to merge this with the main one we have

moldy530 · 2024-11-04T22:52:40Z

account-kit/rn-signer/account-kit-react-native-signer.podspec

NOTE: we're not actually building on iOS, but this was autogenerated

moldy530 · 2024-11-04T22:53:17Z

Most of this was autogenerated by create-react-native-library

.../rn-signer/android/src/main/java/com/accountkit/reactnativesigner/ReactNativeSignerModule.kt

moldy530 · 2024-11-04T22:54:49Z

account-kit/rn-signer/src/NativeTEKStamper.ts

This is the Spec for the stamper as defined in the Eng Spec

rthomare · 2024-11-05T17:42:51Z

account-kit/rn-signer/example/ios/Podfile

Do we need a pod file for example? I guess if we want to pull complied versions of our library in? Also did RN suggest doing a pod file over using swift package manager? I imagine we'd have to support both.

Side note not work blocking on this until we start to support iOS.

this was all autogenerated by the rn library tool. we should definitely migrate this stuff to swift when we build out iOS and use the right package manager

rthomare · 2024-11-05T17:44:38Z

account-kit/rn-signer/example/ios/ReactNativeSignerExample/AppDelegate.h

Is it intentional to do an objective c app or are we trying to do swift? I'd suggest we do swift for the iOS app. Happy to not inlucde this or add a todo to move this to swift if it's blocking.

not intentional at all, this is all from the react lib cli

rthomare · 2024-11-05T17:45:35Z

account-kit/rn-signer/example/ios/ReactNativeSignerExample/LaunchScreen.storyboard

Note to us we'll want to do a storyboard less iOS app for simplicity and to simplify contribution.

moldy530 · 2024-11-12T16:23:22Z

All of the CI failures are fixed upstream in #1134 and #1144

# Pull Request Checklist - [ ] Did you add new tests and confirm existing tests pass? (`yarn test`) - [ ] Did you update relevant docs? (docs are found in the `site` folder, and guidelines for updating/adding docs can be found in the [contribution guide](https://github.com/alchemyplatform/aa-sdk/blob/main/CONTRIBUTING.md)) - [x] Do your commits follow the [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/) standard? - [x] Does your PR title also follow the [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/) standard? - [x] If you have a breaking change, is it [correctly reflected in your commit message](https://www.conventionalcommits.org/en/v1.0.0/#examples)? (e.g. `feat!: breaking change`) - [x] Did you run lint (`yarn lint:check`) and fix any issues? (`yarn lint:write`) - [x] Did you follow the [contribution guidelines](https://github.com/alchemyplatform/aa-sdk/blob/main/CONTRIBUTING.md)?

vercel bot had a problem deploying to Preview – aa-sdk-site November 4, 2024 21:51 Failure

vercel bot had a problem deploying to Preview – aa-sdk-ui-demo November 4, 2024 21:53 Failure

moldy530 force-pushed the moldy/rn-base branch 2 times, most recently from d234c35 to 0e2844a Compare November 4, 2024 22:50

moldy530 commented Nov 4, 2024

View reviewed changes

.../rn-signer/android/src/main/java/com/accountkit/reactnativesigner/ReactNativeSignerModule.kt Outdated Show resolved Hide resolved

moldy530 commented Nov 4, 2024

View reviewed changes

account-kit/rn-signer/src/NativeTEKStamper.ts Outdated

Copy link

Collaborator Author

moldy530 Nov 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the Spec for the stamper as defined in the Eng Spec

vercel bot had a problem deploying to Preview – aa-sdk-site November 4, 2024 22:58 Failure

vercel bot deployed to Preview – aa-sdk-ui-demo November 4, 2024 23:05 View deployment

moldy530 force-pushed the moldy/rn-base branch 2 times, most recently from 4c2a84a to 938f59e Compare November 4, 2024 23:37

vercel bot deployed to Preview – aa-sdk-ui-demo November 4, 2024 23:44 View deployment

vercel bot had a problem deploying to Preview – aa-sdk-site November 4, 2024 23:45 Failure

moldy530 force-pushed the moldy/rn-base branch from 938f59e to a868267 Compare November 5, 2024 00:12

vercel bot had a problem deploying to Preview – aa-sdk-site November 5, 2024 00:14 Failure

vercel bot deployed to Preview – aa-sdk-ui-demo November 5, 2024 00:17 View deployment

moldy530 force-pushed the moldy/rn-base branch from a868267 to 15d1480 Compare November 5, 2024 00:43

vercel bot deployed to Preview – aa-sdk-ui-demo November 5, 2024 00:44 View deployment

vercel bot deployed to Preview – aa-sdk-site November 5, 2024 00:49 View deployment

rthomare reviewed Nov 5, 2024

View reviewed changes

moldy530 force-pushed the moldy/rn-base branch from fd9b2d8 to ea75cd4 Compare November 11, 2024 20:22

vercel bot had a problem deploying to Preview – aa-sdk-site November 11, 2024 20:25 Failure

vercel bot had a problem deploying to Preview – aa-sdk-ui-demo November 11, 2024 20:26 Failure

moldy530 mentioned this pull request Nov 11, 2024

chore: update github actions for rn #1144

Merged

7 tasks

moldy530 marked this pull request as ready for review November 12, 2024 16:22

moldy530 requested review from dancoombs, mokok123, dphilipson and linnall as code owners November 12, 2024 16:22

moldy530 force-pushed the moldy/rn-base branch from ea75cd4 to dcc0df2 Compare November 13, 2024 00:07

vercel bot had a problem deploying to Preview – aa-sdk-ui-demo November 13, 2024 00:09 Failure

vercel bot deployed to Preview – aa-sdk-site November 13, 2024 00:18 View deployment

moldy530 added 7 commits November 14, 2024 21:23

chore(rn): create example from template

ad17977

feat(rn-signer): add key pair generation in android

aae718c

feat(rn): add bundle injection logic

01d7caf

feat(rn): add stamping logic to android stamper

a9e7c93

fix(rn): get login working e2e

95f28d0

refactor(rn): clean things up so they're more digestable

de9be14

chore: update github actions for rn

b201d22

moldy530 force-pushed the moldy/rn-base branch from ee03d62 to 95f28d0 Compare November 15, 2024 02:25

vercel bot had a problem deploying to Preview – aa-sdk-ui-demo November 15, 2024 02:29 Failure

vercel bot deployed to Preview – aa-sdk-site November 15, 2024 02:37 View deployment

moldy530 changed the title ~~chore(rn): create example from template~~ feat(rn): add alpha react native signer impl Nov 15, 2024

vercel bot deployed to Preview – aa-sdk-ui-demo November 15, 2024 22:09 View deployment

vercel bot deployed to Preview – aa-sdk-site November 15, 2024 22:14 View deployment

feat: implement signer create and disconnect methods (#1152)

c360e50

vercel bot deployed to Preview – aa-sdk-ui-demo November 15, 2024 22:54 View deployment

vercel bot deployed to Preview – aa-sdk-site November 15, 2024 22:56 View deployment

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(rn): add alpha react native signer impl #1128

feat(rn): add alpha react native signer impl #1128

moldy530 commented Nov 4, 2024 •

edited by pr-codex bot

Loading

vercel bot commented Nov 4, 2024 •

edited

Loading

moldy530 commented Nov 4, 2024 •

edited

Loading

moldy530 Nov 4, 2024

moldy530 Nov 4, 2024

moldy530 Nov 4, 2024

moldy530 commented Nov 4, 2024

moldy530 Nov 4, 2024

rthomare Nov 5, 2024

moldy530 Nov 5, 2024

rthomare Nov 5, 2024

moldy530 Nov 5, 2024

rthomare Nov 5, 2024

moldy530 commented Nov 12, 2024

feat(rn): add alpha react native signer impl #1128

Are you sure you want to change the base?

feat(rn): add alpha react native signer impl #1128

Conversation

moldy530 commented Nov 4, 2024 • edited by pr-codex bot Loading

Pull Request Checklist

PR-Codex overview

Detailed summary

vercel bot commented Nov 4, 2024 • edited Loading

moldy530 commented Nov 4, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

moldy530 commented Nov 4, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

moldy530 commented Nov 12, 2024

moldy530 commented Nov 4, 2024 •

edited by pr-codex bot

Loading

vercel bot commented Nov 4, 2024 •

edited

Loading

moldy530 commented Nov 4, 2024 •

edited

Loading