Revert "Updated installation, organised and formatted the things" #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmmm, I wonder why it broke. The tests were passing before it was merged. But it seems a couple of cleaver tests are failing here. |
|
yeah I noticed it too! I merged because all the tests had passed, it was only after the merge that everything broke |
|
Could it be due to deleting the cleaver import in the tests_io? |
|
it seems like the GET for urls is not working |
|
So I deleted the cleaver import in the test because it wasn’t actually used within the test module.
…________________________________
From: Beatriz Costa Gomes ***@***.***>
Sent: Wednesday, December 6, 2023 4:00:35 PM
To: alan-turing-institute/profet ***@***.***>
Cc: Parkhurst, James (DLSLtd,RAL,LSCI) ***@***.***>; Review requested ***@***.***>
Subject: Re: [alan-turing-institute/profet] Revert "Updated installation, organised and formatted the things" (PR #46)
it seems like the GET for urls is not working
—
Reply to this email directly, view it on GitHub<#46 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AARDKYMNSTQMKWAD3KO7SLDYIC6FHAVCNFSM6AAAAABAJWLALSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNBTGUYTSNBYGE>.
You are receiving this because your review was requested.Message ID: ***@***.***>
--
This e-mail and any attachments may contain confidential, copyright and or privileged material, and are for the use of the intended addressee only. If you are not the intended addressee or an authorised recipient of the addressee please notify us of receipt by returning the e-mail and do not use, copy, retain, distribute or disclose the information in or attached to the e-mail.
Any opinions expressed within this e-mail are those of the individual and not necessarily of Diamond Light Source Ltd.
Diamond Light Source Ltd. cannot guarantee that this e-mail or any attachments are free from viruses and we cannot accept liability for any damage which you may sustain as a result of software viruses which may be transmitted in or with the message.
Diamond Light Source Limited (company no. 4375679). Registered in England and Wales with its registered office at Diamond House, Harwell Science and Innovation Campus, Didcot, Oxfordshire, OX11 0DE, United Kingdom
|
|
@mooniean I can confirm that the tests fail locally for me. The tests are also failing on my local version and these tests were previously passing. |
|
I fixed the test and made a pull request. |
|
Just approved it, and merged it as well given the change. Absolutely hilarious that that's what broke it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #43
The PR broke profet so I'm reverting, so we can have a PR just with the readme updates and then the other file alterations we do separately.