Fix race-condition in pipe close

akash-akya · Jan 3, 2025 · 2596fbd · 2596fbd
1 parent ee8d8db
commit 2596fbd
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/c_src/pipe.c b/c_src/pipe.c
@@ -385,11 +385,12 @@ static bool cancel_select(ErlNifEnv *env, int *fd) {
 
 static void fd_rt_dtor(ErlNifEnv *env, void *obj) {
   debug("fd_rt_dtor called");
+  int *fd = (int *)obj;
+  close_fd(fd);
 }
 
 static void fd_rt_stop(ErlNifEnv *env, void *obj, int fd, int is_direct_call) {
   debug("fd_rt_stop called %d", fd);
-  close_fd(&fd);
 }
 
 static void fd_rt_down(ErlNifEnv *env, void *obj, ErlNifPid *pid,