Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the cancel button work #24

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

Caraxi
Copy link
Contributor

@Caraxi Caraxi commented Jul 28, 2021

Cancel search when the cancel button is pressed.

@Caraxi
Copy link
Contributor Author

Caraxi commented Mar 1, 2022

Any updates?

@ajkhoury
Copy link
Owner

ajkhoury commented Mar 1, 2022

Maybe I am misinterpreting the code, but what is the point of the extra or in cancelled = cancelled || user_cancelled(); ? Could you not simply do cancelled = user_cancelled();? Or better yet something like the following?

 if (user_cancelled()) {
    cancelled = true;
    break;
}

@Caraxi
Copy link
Contributor Author

Caraxi commented Jul 13, 2022

I don't remember why I did it like that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants