fix: number regex

- add new unit test

pom.xml

@@ -116,6 +116,12 @@
 						<goals>
 							<goal>sign</goal>
 						</goals>
+						<configuration>
+							<gpgArguments>
+								<arg>--pinentry-mode</arg>
+								<arg>loopback</arg>
+							</gpgArguments>
+						</configuration>
 					</execution>
 				</executions>
 			</plugin>

src/main/java/io/github/ajclopez/mss/MongoSpringSearch.java

@@ -1,28 +1,23 @@
 package io.github.ajclopez.mss;
 
-import java.util.ArrayList;
-import java.util.List;
-import java.util.Map;
-import java.util.Optional;
-import java.util.regex.Matcher;
-import java.util.stream.Collectors;
-
+import io.github.ajclopez.mss.criteria.CriteriaImpl;
+import io.github.ajclopez.mss.criteria.CriteriaQueryVisitor;
+import io.github.ajclopez.mss.exception.ArgumentNotValidException;
+import io.github.ajclopez.mss.model.*;
+import io.github.ajclopez.mss.parser.QueryParser;
+import io.github.ajclopez.mss.pattern.SearchPatterns;
 import org.antlr.v4.runtime.CharStreams;
 import org.antlr.v4.runtime.CommonTokenStream;
 import org.springframework.data.domain.Sort;
 import org.springframework.data.mongodb.core.query.Criteria;
 import org.springframework.data.mongodb.core.query.Query;
 
-import io.github.ajclopez.mss.criteria.CriteriaImpl;
-import io.github.ajclopez.mss.criteria.CriteriaQueryVisitor;
-import io.github.ajclopez.mss.exception.ArgumentNotValidException;
-import io.github.ajclopez.mss.model.CastType;
-import io.github.ajclopez.mss.model.Configuration;
-import io.github.ajclopez.mss.model.KeySearchOperation;
-import io.github.ajclopez.mss.model.SearchCriteria;
-import io.github.ajclopez.mss.model.SortSearchOperation;
-import io.github.ajclopez.mss.parser.QueryParser;
-import io.github.ajclopez.mss.pattern.SearchPatterns;
+import java.util.ArrayList;
+import java.util.List;
+import java.util.Map;
+import java.util.Optional;
+import java.util.regex.Matcher;
+import java.util.stream.Collectors;
 
 /**
  * 
@@ -78,7 +73,7 @@ public static Query mss(String query, Optional<Configuration> configuration) thr
 				filters.add(criteria);
 				break;
 			case FILTER:
-				filterCriteria = parseFilterAdvanced(mongoQuery, criteria.getValue(), casters);
+				filterCriteria = parseFilterAdvanced(criteria.getValue(), casters);
 				break;
 			case SKIP:
 				parseSkip(mongoQuery, criteria.getValue());
@@ -189,7 +184,7 @@ private static void parseSort(Query query, String value) {
 		}
 	}
 
-	private static Criteria parseFilterAdvanced(Query query, String input, Map<String, CastType> casters) {
+	private static Criteria parseFilterAdvanced(String input, Map<String, CastType> casters) {
 
 		QueryLexer lexer = new QueryLexer(CharStreams.fromString(input));
 		CommonTokenStream tokens = new CommonTokenStream(lexer);

src/main/java/io/github/ajclopez/mss/parser/QueryParser.java

@@ -1,5 +1,11 @@
 package io.github.ajclopez.mss.parser;
 
+import io.github.ajclopez.mss.exception.ArgumentNotValidException;
+import io.github.ajclopez.mss.model.CastType;
+import io.github.ajclopez.mss.model.SearchCriteria;
+import io.github.ajclopez.mss.model.SearchOperation;
+import io.github.ajclopez.mss.pattern.SearchPatterns;
+
 import java.net.URLDecoder;
 import java.nio.charset.StandardCharsets;
 import java.text.NumberFormat;
@@ -15,12 +21,6 @@
 import java.util.regex.Matcher;
 import java.util.regex.Pattern;
 
-import io.github.ajclopez.mss.exception.ArgumentNotValidException;
-import io.github.ajclopez.mss.model.CastType;
-import io.github.ajclopez.mss.model.SearchCriteria;
-import io.github.ajclopez.mss.model.SearchOperation;
-import io.github.ajclopez.mss.pattern.SearchPatterns;
-
 /**
  * 
  * Class used to parse a search query {@code String} and create a list of {@link SearchCriteria}.
@@ -81,11 +81,11 @@ public static SearchCriteria criteriaParser(String condition, Map<String, CastTy
 
 	/**
 	 * 
-	 * The value is automatically casted: {@code Number, Date, Boolean, RegExp, String, List}.
+	 * The value is automatically cast: {@code Number, Date, Boolean, RegExp, String, List}.
 	 * 
 	 * @param value The value will be cast.
 	 * @param caster Specify casting per value.
-	 * @return Object Casted to {@code Number, Date, Boolean, RegExp, String, List}.
+	 * @return Object Cast to {@code Number, Date, Boolean, RegExp, String, List}.
 	 */
 	public static Object parseValue(String value, CastType caster) {
 

src/main/java/io/github/ajclopez/mss/pattern/SearchPatterns.java

@@ -12,7 +12,7 @@ public class SearchPatterns {
     private static final String OPERATOR_PATTERN = "(!?)([^><!=]+)([><]=?|!?=|)(.*)";
     private static final String REGEX_PATTERN = "^/(.*)/([igmsx]*)$";
     private static final String SORT_PATTERN = "^(\\+|-)?(.*)";
-    private static final String NUMBER_PATTERN = "^(-?)(\\d+)([,.0-9]*)$";
+    private static final String NUMBER_PATTERN = "^(-?)(\\d+)([.0-9]*)$";
 
     private static Pattern operatorPattern;
     private static Pattern regExpPattern;

src/test/java/io/github/ajclopez/mss/MongoSpringSearchTest.java

@@ -1,5 +1,15 @@
 package io.github.ajclopez.mss;
 
+import com.mongodb.BasicDBList;
+import io.github.ajclopez.mss.exception.ArgumentNotValidException;
+import io.github.ajclopez.mss.model.CastType;
+import io.github.ajclopez.mss.model.Configuration;
+import io.github.ajclopez.mss.model.LogicalOperation;
+import org.bson.Document;
+import org.junit.Assert;
+import org.junit.Test;
+import org.springframework.data.mongodb.core.query.Query;
+
 import java.time.Clock;
 import java.time.Instant;
 import java.time.ZoneId;
@@ -9,17 +19,6 @@
 import java.util.Optional;
 import java.util.regex.Pattern;
 
-import org.bson.Document;
-import org.junit.Assert;
-import org.junit.Test;
-import org.springframework.data.mongodb.core.query.Query;
-
-import com.mongodb.BasicDBList;
-
-import io.github.ajclopez.mss.exception.ArgumentNotValidException;
-import io.github.ajclopez.mss.model.CastType;
-import io.github.ajclopez.mss.model.Configuration;
-
 public class MongoSpringSearchTest {
 
 
@@ -322,7 +321,7 @@ public void canUseCastingPattern() {
 	@Test
 	public void complexQuery() {
 
-		String query = "filter=(city=Madrid or city=Spanin) and gender=female"
+		String query = "filter=(city=Madrid or city=Barcelona) and gender=female"
 				+ "&skip=50"
 				+ "&limit=10"
 				+ "&sort=-birthday"
@@ -341,5 +340,13 @@ public void complexQuery() {
 		Assert.assertEquals(Integer.valueOf(1), mongoQuery.getFieldsObject().getInteger("age"));
 		Assert.assertEquals(Integer.valueOf(-1), mongoQuery.getSortObject().getInteger("birthday"));
 	}
+
+	@Test
+	public void whenUseInvalidLogicalOperator() {
+
+		LogicalOperation result = LogicalOperation.getLogicalOperation("y");
+		Assert.assertEquals(null, result);
+
+	}
 
 }

src/test/java/io/github/ajclopez/mss/QueryParserTest.java

@@ -0,0 +1,43 @@
+package io.github.ajclopez.mss;
+
+import io.github.ajclopez.mss.model.CastType;
+import io.github.ajclopez.mss.model.SearchCriteria;
+import io.github.ajclopez.mss.parser.QueryParser;
+import org.junit.Assert;
+import org.junit.Test;
+
+import java.util.regex.Pattern;
+
+public class QueryParserTest {
+
+
+    @Test
+    public void whenQueryNotMatchThenReturnNull() {
+
+        SearchCriteria result = QueryParser.criteriaParser("", null);
+        Assert.assertEquals(null, result);
+    }
+
+    @Test
+    public void whenRegexNotMatchWithPatternThenReturnPatternWithValue() {
+
+        String regex = "^58";
+        Object result = QueryParser.parseValue(regex, CastType.PATTERN);
+        Assert.assertEquals(Pattern.compile(regex).toString(), result.toString());
+    }
+
+    @Test
+    public void whenFalseValueThenReturnBooleanWithFalseValue() {
+
+        Object result = QueryParser.parseValue("false", null);
+        Assert.assertEquals(Boolean.parseBoolean("false"), result);
+    }
+
+    @Test
+    public void whenValueIsNullThenReturnNullValue() {
+
+        Object result = QueryParser.parseValue(null, null);
+        Assert.assertEquals(null, result);
+    }
+
+}

src/test/java/io/github/ajclopez/mss/SearchPatternsTest.java

@@ -0,0 +1,21 @@
+package io.github.ajclopez.mss;
+
+import io.github.ajclopez.mss.pattern.SearchPatterns;
+import org.junit.Assert;
+import org.junit.Test;
+
+public class SearchPatternsTest {
+
+    @Test
+    public void canUseDefaultFlagWithNullOptions() {
+        int flags = SearchPatterns.getFlags(null);
+        Assert.assertEquals(0x00, flags);
+    }
+
+    @Test
+    public void canUseDefaultFlagWithUnknownRegexFlag() {
+        int flags = SearchPatterns.getFlags("t");
+        Assert.assertEquals(0x00, flags);
+    }
+
+}