-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added position
argument so pick
doesn't clear the screen every time
#95
Conversation
WalkthroughThe update introduces an optional Changes
Recent Review DetailsConfiguration used: CodeRabbit UI Files selected for processing (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
Actionable comments outside the diff hunks (1)
src/pick/__init__.py (1)
Line range hint
166-166
: Avoid using a bareexcept
statement. Specify the exceptions you expect to handle to prevent masking other unexpected issues.- except: + except Exception as e:
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
Hi, I think this change looks good to me, but before merge, we need to resolve the conflicts. |
Is that something for me or you to do? If it's me, how? |
You can execute Otherwise, you can edit the file as normal file, and edit it by hand, to make it as what it expected to commit. After that, just running Last way is click the |
Did this, nothing happened other than the normal output like with
I went to edit the file and it looked the same as what I had committed? I didn't change anything so there's nothing to push back Do I use GitHub's |
You can have a try to use the |
done :) |
Thank you for your contribution, merged! |
#94 #50
I have added the
position
argument to thepick
module, so that a specific write-point can be provided. This means thatpick
won't clear the screen when running in an existingcurses
windowposition
is a dictionary with the keysy0
andx0
, which correspond to they
andx
locations respectively. Default position is the same as previously, now written as{"y0": 1, "x0": 1}
Forked repo here
Summary by CodeRabbit
New Features
position
parameter to set the initial cursor position in the user interface.Documentation