Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Source E-Commerce: fix start date parameter in spec #48564

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

mombrea
Copy link

@mombrea mombrea commented Nov 19, 2024

What

Fixes #34133

Currently you cannot set up a commercetools source because the new connection form requires a Start Date in the date only format YYYY-MM-DD however the connection manifest requires a date-time format and is self conflicting.

How

The manifest spec has been updated to change the start_date property format to date

Review guide

  1. airbyte-integrations/connectors/source-commercetools/source_commercetools/manifest.yaml
  2. airbyte-integrations/connectors/source-commercetools/metadata.yaml

User Impact

Users can now create commercetools source connections

Can this PR be safely reverted and rolled back?

  • YES 💚
  • NO ❌

Copy link

vercel bot commented Nov 19, 2024

@mombrea is attempting to deploy a commit to the Airbyte Growth Team on Vercel.

A member of the Team first needs to authorize it.

@octavia-squidington-iii octavia-squidington-iii added the area/documentation Improvements or additions to documentation label Nov 20, 2024
@mombrea mombrea deployed to community-ci-auto November 20, 2024 14:33 — with GitHub Actions Active
@mombrea mombrea changed the title Source CommerceTools: JSON Schema start_date is self-conflicting; impossible to fill out. 🐛 Source E-Commerce: fix start date parameter in spec Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation community connectors/source/commercetools
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Source CommerceTools: JSON Schema start_date is self-conflicting; impossible to fill out.
2 participants