Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛Source Datadog: update incremental sync date parameter with OR fields for missing config #48537

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

🐛Source Datadog: update incremental sync date parameter with OR fields for missing config #48537

wants to merge 2 commits into from
+34 −33

Conversation

btkcodedev
Copy link
Collaborator

@btkcodedev btkcodedev commented Nov 18, 2024 •
edited
Loading

What

Closes #46549
For logs stream, the optional start_date and end_date parameters are needed, but incase if its not configured, the streams would give error logs.

How

Fixed with optional dates if dates are not configured

@vercel Vercel
Copy link

vercel bot commented Nov 18, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 18, 2024 3:53pm

@btkcodedev btkcodedev changed the title update incremental sync date parameter with or fields in case of miss… 🐛Source Datadog: update incremental sync date parameter with OR fields for missing config Nov 18, 2024
@octavia-squidington-iv octavia-squidington-iv requested a review from a team November 18, 2024 15:39
@btkcodedev btkcodedev self-assigned this Nov 18, 2024
@btkcodedev
Copy link
Collaborator Author

btkcodedev commented Nov 18, 2024 •
edited
Loading

Short summary:

Problem: logs stream gives error - time data '' does not match format '%Y-%m-%dT%H:%M:%SZ'
Cause: start_date and end_date are optional parameters, most probably user hasn't configured it
Fix:

  1. One is breaking change requiring start_date and end_date to be required
  2. Second is a patch by giving some default dates for the logs stream if it's not configured

@btkcodedev
Copy link
Collaborator Author

btkcodedev commented Nov 18, 2024 •
edited
Loading

The second fix is applied as it is optimal and doesn't affect a lot of users

@btkcodedev
Copy link
Collaborator Author

btkcodedev commented Nov 18, 2024 •
edited by github-actions bot
Loading

/bump-version type="patch" changelog="Give start and end dates for logs stream, if they are not configured as default"

Bump Version job started... Check job output.

✅ Changes applied successfully. (78ba48d)

@octavia-squidington-iii octavia-squidington-iii added the area/documentation Improvements or additions to documentation label Nov 18, 2024
@btkcodedev btkcodedev enabled auto-merge (squash) November 19, 2024 01:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcosmarxm marcosmarxm Awaiting requested review from marcosmarxm

At least 1 approving review is required to merge this pull request.

Assignees

@btkcodedev btkcodedev

Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/datadog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[source-datadog] raise ValueError("time data %r does not match format %r" %..)
2 participants
@btkcodedev @octavia-squidington-iii