Add mysql service connectivity check #79
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's similar to haproxy option mysql-check, and is used for local mysql service check. A simple mysql-check uses a user with minimal USAGE privilege and the user may or may not have a password.
|
|
||
| begin | ||
| log.debug "nerve: mysql connect #{@host}:#{@port} as #{@user}" | ||
| conn = Mysql2::Client.new(:host => @host, :username => @user, :password => @pass, :port => @port) |
There was a problem hiding this comment.
i think timeouts are integral to the notion of a health check. is there a way to specify a connection timeout for Mysql2 ? i don't think we should merge without it.
|
can you investigate the spec failure? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The mysql service connectivity check is similar to haproxy option mysql-check, and is used for local
mysql service check. A simple mysql-check uses a user with minimal USAGE privilege and the user may or may not have a password. In our company production, we use haproxy option mysql-check for synapse side service health check, however it does not work with a new db proxy service that we build, and the nerve tcp port health check on the local server is not sufficient. The simple mysql service check borrows the idea of haproxy option mysql-check but it uses mysql client and therefore works with the new proxy. It had been verified in our production test environment.
@igor47